Skip to content

use = instead of LIKE for email lookups #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmyui merged 1 commit into from
Apr 3, 2026
Merged

use = instead of LIKE for email lookups #255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/handlers/profiles/settings/password.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ func ChangePasswordSubmitHandler(c *gin.Context) {
services.DB.Get(&currentEmail, "SELECT email FROM users WHERE id = ?", ctx.User.ID)

if email != "" && email != currentEmail {
if services.DB.QueryRow("SELECT 1 FROM users WHERE email LIKE ?", email).
if services.DB.QueryRow("SELECT 1 FROM users WHERE email = ?", email).
Scan(new(int)) != sql.ErrNoRows {
messages = append(messages, msg.ErrorMessage{lu.T(c, "This email is already in use!")})
return
Expand Down
2 changes: 1 addition & 1 deletion app/handlers/sessions/register/register.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ func RegisterSubmitHandler(c *gin.Context) {
}

// check whether an user with that email already exists
if services.DB.QueryRow("SELECT 1 FROM users WHERE email LIKE ?", email).
if services.DB.QueryRow("SELECT 1 FROM users WHERE email = ?", email).
Scan(new(int)) != sql.ErrNoRows {
registerResp(c, msg.ErrorMessage{lu.T(c, "An user with that email address already exists!")})
return
Expand Down