fix private match access check boolean logic#254
Closed
raya-ac wants to merge 1 commit into
Closed
Conversation
raya-ac
requested review from
cmyui,
infernalfire72 and
lenforiee
as code owners
cmyui
reviewed
Apr 3, 2026
| if privateMatch && | ||
| (!inList(participantsIds, ctx.User.ID) || | ||
| (!inList(participantsIds, ctx.User.ID) && | ||
| ctx.User.Privileges&common.UserPrivilegeTournamentStaff == 0) { |
Member
There was a problem hiding this comment.
i think this is intentional?
if it's a private match, and if theyre either (not in match or not staff), then reject
Member
There was a problem hiding this comment.
if they were in the match or if they are an admin, they can see it
negate it and it becomes if they were not in the match and they are not an admin, they cant see it (or -> and)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #249
Changed || to && so access is denied only when the user is neither a participant nor tournament staff.