Disable language selection UI & auto-discovery#175
Open
cmyui wants to merge 1 commit into
Open
Conversation
cmyui
requested review from
infernalfire72,
lenforiee and
tsunyoku
as code owners
cmyui
commented
Oct 28, 2024
| return localeEngine.Get(GetLang(c), s, args...) | ||
| } | ||
|
|
||
| func getQuality(s string) float32 { |
Member
Author
There was a problem hiding this comment.
Moved this stuff in from /internal/locale/parse_header.go, and removed it; seems superfluous
cmyui
commented
Oct 28, 2024
|
|
||
| ctx.Language = lu.GetLanguageFromGin(c) | ||
| // XXX: Disabled Oct 2024 due to very poor coverage | ||
| ctx.Language = "en" |
Member
Author
There was a problem hiding this comment.
See available languages (taken from cost) below:
{"de", "pl", "it", "es", "ru", "fr", "nl", "ro", "fi", "sv", "vi", "ko"}
Member
|
Perhaps we can hide it behind amplitude flag instead of completely commenting it out? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the language selector from the website footer, and removes language discovery/sets all sessions to "en".
Turning on any language is a mess of 1/4-translated pages, and I think it's much better to disable, and only consider re-enabling once it's in a respectable state (e.g. after we have tooling to generate *.po files, and we hire a set of translators to translate the unmapped entries).