Custom Ranked Akatsuki Maps API#29
Open
sjb8108 wants to merge 6 commits into
Open
Conversation
…eatmaps with custom akatsuki status in service layer
for more information, see https://pre-commit.ci
cmyui
reviewed
Jul 31, 2025
cmyui
reviewed
Jul 31, 2025
cmyui
reviewed
Jul 31, 2025
| client_ip_address: str | None = Header(None, alias="X-Real-IP"), | ||
| client_user_agent: str | None = Header(None, alias="User-Agent"), | ||
| ) -> Response: | ||
| # idk if stuff above with get_beatmap is needed |
Member
There was a problem hiding this comment.
Suggested change
| # idk if stuff above with get_beatmap is needed |
Member
There was a problem hiding this comment.
for uncertainties like this, it's better to add them as PR comments (like i'm doing here) before sending it out for review, as opposed to code comments
cmyui
requested changes
Jul 31, 2025
cmyui
left a comment
cmyui
left a comment
Member
There was a problem hiding this comment.
left a few comments for changes, but generally lgtm! nice work!
…i/beatmaps-service into akatsuki-beatmaps-api
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version 1 of the API that would allow users access information about custom ranked/loved beatmaps on Akatsuki.