sources: add missing headers to the install list#895
Merged
Conversation
These public headers existed on disk under src/ossia but were absent from the install list in ossia_sources.cmake, so they were not installed into the SDK. Downstream JIT/SDK consumers then failed with "file not found" when including them (directly or transitively via listed siblings). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A number of public headers under
src/ossia/...exist on disk but were not enumerated insrc/ossia_sources.cmake. Because the install rules iterate over the*_HEADERSlists in that file, these headers were never installed into the SDK. Downstream JIT/SDK consumers that include them — directly, or transitively through already-installed sibling headers — then fail at configure/compile time withfile not found.Fix
Add the missing headers to the appropriate
*_HEADERSgroup inossia_sources.cmake, matching the surrounding ordering/grouping. Each added header sits alongside siblings that were already listed (e.g. other framing variants innetwork/sockets/, otherdetail/utilities, thedense_protocol/phidgets/detailsiblings, etc.).Headers added (15)
ossia/detail/sleep.hppossia/detail/thread_priority.hppossia/detail/unique_instance.hppossia/detail/yield.hppossia/network/http/http_client_request.hppossia/network/sockets/cobs_framing.hppossia/network/sockets/encoding.hppossia/network/sockets/fixed_length_framing.hppossia/network/sockets/stx_etx_framing.hppossia/network/sockets/var_size_prefix_framing.hppossia/protocols/dense/dense_protocol_configuration.hppossia/protocols/oscquery/http_requests.hppossia/protocols/oscquery/oscquery_fwd.hppossia/protocols/phidgets/detail/phidgetspp.hppossia/audio/asio_protocol.hpp(
http_client_request.hppis added in both theAPI_HEADERSandOSSIA_OSCQUERY_HEADERSgroups, matching the existing duplicate listing of the othernetwork/http/headers — hence 16 inserted lines for 15 unique headers.)Deliberately skipped
ossia/protocols/leapmotion/leapmotion_device.hpp— empty 0-byte stub, its.cppis also empty, andleapmotionis not referenced by any CMake list or source. This is an intentionally-unbuilt placeholder, not a public API header.🤖 Generated with Claude Code