Skip to content

sources: add missing headers to the install list#895

Merged
jcelerier merged 1 commit into
masterfrom
fix/install-missing-headers
Jun 20, 2026
Merged

sources: add missing headers to the install list#895
jcelerier merged 1 commit into
masterfrom
fix/install-missing-headers

Conversation

@jcelerier

Copy link
Copy Markdown
Member

Problem

A number of public headers under src/ossia/... exist on disk but were not enumerated in src/ossia_sources.cmake. Because the install rules iterate over the *_HEADERS lists in that file, these headers were never installed into the SDK. Downstream JIT/SDK consumers that include them — directly, or transitively through already-installed sibling headers — then fail at configure/compile time with file not found.

Fix

Add the missing headers to the appropriate *_HEADERS group in ossia_sources.cmake, matching the surrounding ordering/grouping. Each added header sits alongside siblings that were already listed (e.g. other framing variants in network/sockets/, other detail/ utilities, the dense_protocol / phidgets/detail siblings, etc.).

Headers added (15)

  • ossia/detail/sleep.hpp
  • ossia/detail/thread_priority.hpp
  • ossia/detail/unique_instance.hpp
  • ossia/detail/yield.hpp
  • ossia/network/http/http_client_request.hpp
  • ossia/network/sockets/cobs_framing.hpp
  • ossia/network/sockets/encoding.hpp
  • ossia/network/sockets/fixed_length_framing.hpp
  • ossia/network/sockets/stx_etx_framing.hpp
  • ossia/network/sockets/var_size_prefix_framing.hpp
  • ossia/protocols/dense/dense_protocol_configuration.hpp
  • ossia/protocols/oscquery/http_requests.hpp
  • ossia/protocols/oscquery/oscquery_fwd.hpp
  • ossia/protocols/phidgets/detail/phidgetspp.hpp
  • ossia/audio/asio_protocol.hpp

(http_client_request.hpp is added in both the API_HEADERS and OSSIA_OSCQUERY_HEADERS groups, matching the existing duplicate listing of the other network/http/ headers — hence 16 inserted lines for 15 unique headers.)

Deliberately skipped

  • ossia/protocols/leapmotion/leapmotion_device.hpp — empty 0-byte stub, its .cpp is also empty, and leapmotion is not referenced by any CMake list or source. This is an intentionally-unbuilt placeholder, not a public API header.

🤖 Generated with Claude Code

These public headers existed on disk under src/ossia but were absent
from the install list in ossia_sources.cmake, so they were not installed
into the SDK. Downstream JIT/SDK consumers then failed with "file not
found" when including them (directly or transitively via listed siblings).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@jcelerier jcelerier temporarily deployed to Apple Certificate June 20, 2026 06:18 — with GitHub Actions Inactive
@jcelerier jcelerier temporarily deployed to Apple Certificate June 20, 2026 06:18 — with GitHub Actions Inactive
@jcelerier jcelerier temporarily deployed to Apple Certificate June 20, 2026 06:18 — with GitHub Actions Inactive
@jcelerier jcelerier temporarily deployed to Apple Certificate June 20, 2026 06:18 — with GitHub Actions Inactive
@jcelerier jcelerier temporarily deployed to Apple Certificate June 20, 2026 06:18 — with GitHub Actions Inactive
@jcelerier jcelerier temporarily deployed to Apple Certificate June 20, 2026 06:18 — with GitHub Actions Inactive
@jcelerier jcelerier temporarily deployed to Apple Certificate June 20, 2026 06:18 — with GitHub Actions Inactive
@jcelerier jcelerier temporarily deployed to Apple Certificate June 20, 2026 06:18 — with GitHub Actions Inactive
@jcelerier jcelerier temporarily deployed to Apple Certificate June 20, 2026 06:18 — with GitHub Actions Inactive
@jcelerier jcelerier temporarily deployed to Apple Certificate June 20, 2026 06:18 — with GitHub Actions Inactive
@jcelerier jcelerier temporarily deployed to Apple Certificate June 20, 2026 06:18 — with GitHub Actions Inactive
@jcelerier jcelerier merged commit 476e6e5 into master Jun 20, 2026
46 checks passed
@jcelerier jcelerier deleted the fix/install-missing-headers branch June 20, 2026 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant