fmt: support fmt 12.2#893
Closed
jcelerier wants to merge 1 commit into
Closed
Conversation
jcelerier
temporarily deployed
to
Apple Certificate
GitHub Actions
Inactive
jcelerier
temporarily deployed
to
Apple Certificate
GitHub Actions
Inactive
jcelerier
temporarily deployed
to
Apple Certificate
GitHub Actions
Inactive
jcelerier
temporarily deployed
to
Apple Certificate
GitHub Actions
Inactive
jcelerier
temporarily deployed
to
Apple Certificate
GitHub Actions
Inactive
jcelerier
temporarily deployed
to
Apple Certificate
GitHub Actions
Inactive
jcelerier
temporarily deployed
to
Apple Certificate
GitHub Actions
Inactive
jcelerier
temporarily deployed
to
Apple Certificate
GitHub Actions
Inactive
jcelerier
temporarily deployed
to
Apple Certificate
GitHub Actions
Inactive
jcelerier
temporarily deployed
to
Apple Certificate
GitHub Actions
Inactive
jcelerier
temporarily deployed
to
Apple Certificate
GitHub Actions
Inactive
- bump vendored fmt to 12.2 and spdlog to a matching commit - stop forcing FMT_USE_INT128=0: in fmt 12.2 defining it (to 0 or 1) suppresses the native_int128 declaration and the software fallback lacks operator~, so format_hexfloat fails to build. Let fmt auto-detect __int128 instead. - flat_set formatter: fmt 12 renamed detail::is_container_adaptor_like to is_container_adaptor and moved it out of the detail namespace. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UJoeDPZWGZMVPe65Np4f2F
jcelerier
force-pushed
the
claude/fmt-12.2-compat
branch
from
6043bb9 to
f1a6528
Compare
jcelerier
temporarily deployed
to
Apple Certificate
GitHub Actions
Inactive
jcelerier
temporarily deployed
to
Apple Certificate
GitHub Actions
Inactive
jcelerier
temporarily deployed
to
Apple Certificate
GitHub Actions
Inactive
jcelerier
temporarily deployed
to
Apple Certificate
GitHub Actions
Inactive
jcelerier
temporarily deployed
to
Apple Certificate
GitHub Actions
Inactive
jcelerier
temporarily deployed
to
Apple Certificate
GitHub Actions
Inactive
jcelerier
temporarily deployed
to
Apple Certificate
GitHub Actions
Inactive
jcelerier
temporarily deployed
to
Apple Certificate
GitHub Actions
Inactive
jcelerier
temporarily deployed
to
Apple Certificate
GitHub Actions
Inactive
jcelerier
temporarily deployed
to
Apple Certificate
GitHub Actions
Inactive
jcelerier
temporarily deployed
to
Apple Certificate
GitHub Actions
Inactive
jcelerier
added a commit
to ossia/score
that referenced
this pull request
Jun 19, 2026
Pulls in ossia/libossia#893 (fmt 12.2 + spdlog bump). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UJoeDPZWGZMVPe65Np4f2F
3 tasks
jcelerier
pushed a commit
that referenced
this pull request
Jun 20, 2026
This branch combines #892 (keep a winsock instance alive during tests) and #893 (fmt 12.2 support) and adds the remaining fixes needed to get the Windows CI fully green. WSLogger: the test relied on fixed 100ms windows to complete an asynchronous, cross-thread websocket handshake. On the slow static Debug Windows runner that is not enough, so `REQUIRE(opened)` failed intermittently even with the winsock fix in place. Pump the server io_context until each step (open, message, close) is actually observed instead, with a generous 15s upper bound so a real regression still fails in reasonable time. ossia-pd / ossia-purrdata: the build-windows (and build-linux) jobs were missing -DCMAKE_POLICY_VERSION_MINIMUM=3.5, so CMake >= 4.0 now hard-errors on CicmWrapper's `cmake_minimum_required(VERSION < 3.5)`. Add the flag to match the build-macos invocation that already carried it. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RhPCgbU8RNRmKxSfXwhWog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds against fmt 12.2 (the version now shipping on e.g. Arch).
FMT_USE_INT128=0: in fmt 12.2, defining the macro (to 0 or 1) suppresses thenative_int128declaration, and the software fallbackuint128lacksoperator~, soformat_hexfloatfails to compile. Letting fmt auto-detect__int128uses the native type where available and the (working) 64-bit path on MSVC.flat_setformatter: fmt 12 renameddetail::is_container_adaptor_like->is_container_adaptorand promoted it out of thedetailnamespace (version-guarded for fmt 10/11).🤖 Generated with Claude Code
https://claude.ai/code/session_01UJoeDPZWGZMVPe65Np4f2F