win32: keep a winsock instance alive during tests to fix spurious CI failures#892
Open
jcelerier wants to merge 1 commit into
Open
win32: keep a winsock instance alive during tests to fix spurious CI failures#892jcelerier wants to merge 1 commit into
jcelerier wants to merge 1 commit into
Conversation
Restore the lost fix (originally e5ea48d) for the spurious Win32 CI test failures: keep a WinSock instance alive for the whole lifetime of the test process via a static owner struct in the shared Catch test header.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores the lost fix (originally
e5ea48d) for the spurious Win32 CI test failures caused by WinSock being torn down between operations.asio refcounts
WSAStartup/WSACleanupper object, so during the test run WinSock can be cleaned up between operations, producing intermittent socket failures on the Win32 runners (e.g. https://github.com/ossia/libossia/actions/runs/27264509297/job/80518258354).The fix keeps a WinSock instance alive for the whole lifetime of the test process via a static owner struct in the shared Catch test header (
tests/catch/include_catch.hpp), which every test pulls in. Library code is unchanged.Test plan
https://claude.ai/code/session_01XRmDZYxYXvYGHnnAVQ3j9T
Generated by Claude Code