Conversation
✅MegaLinter analysis: Success
See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
ideaship
marked this pull request as ready for review
September 29, 2026 08:14
jklare
self-requested a review
September 29, 2026 08:15
jklare
reviewed
Sep 29, 2026
jklare
reviewed
Sep 29, 2026
jklare
reviewed
Sep 29, 2026
jklare
reviewed
Sep 29, 2026
jklare
reviewed
Sep 29, 2026
jklare
reviewed
Sep 29, 2026
Contributor
|
LGTM, thanks for writing and testing this. I will give it a try before approving and merging. |
The section has four pages. index.md orients the reader and scopes the guide to a single-shard deployment, which is what OSISM deploys by default. backup.mdx covers which host holds the archives and how to find it, taking full and incremental backups, confirming that a run succeeded, copying the archives off the database hosts, and scheduling runs with a prune script to bound what they accumulate. It leads with a defect: on OSISM 10.2.0 and earlier, mariabackup locks one node and copies another, so an archive can record a binary log position belonging to a different node and restore cleanly to the wrong state. connection-fix.md documents that defect, both where the internal API address is a keepalived VIP and where it is a BGP anycast address announced by every control node, how to tell whether a deployment is exposed, the configuration overlay that corrects it, what to do about archives taken before it was applied, and how to revert the overlay once an upgrade carries the upstream fix. restore.md is the procedure: prerequisites, extracting and preparing an archive before the outage, stopping the cluster, replacing the data, recovering the cluster from the restored node, verifying before returning to service, and reclaiming the scratch space. It also covers restoring to an incremental backup, and reconciling the database against OVN, Ceph and the hypervisors afterwards, since a restore moves only MariaDB and leaves every backing store holding resources the database no longer knows about. The procedure was followed end to end on a live 2026.1 cluster, including a destructive restore from a full plus one increment. infrastructure.md still carries the sections this replaces; the next commit retires them. Assisted-by: Claude:claude-opus-5 Signed-off-by: Roger Luethi <luethi@osism.tech>
The Backup and Restore subsections under MariaDB are replaced by the guide added in the previous commit. It covers the same ground in more detail, and for the archive layout OSISM has used since 9.2.0. Replace them with a pointer to the new section. The Recovery subsection stays: bringing back a cluster that stopped with its data intact is a routine operation rather than part of backing up or restoring, and it is handled separately. So does the rest of the MariaDB material, since creating a database and user is not part of backing one up either. Assisted-by: Claude:claude-opus-5 Signed-off-by: Roger Luethi <luethi@osism.tech>
ideaship
force-pushed
the
docs/mariadb-guide
branch
from
September 29, 2026 09:43
6466bd1 to
6261337
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Adds a MariaDB backup and restore section to the operations guide, and retires the
three subsections under MariaDB in
infrastructure.mdthat it replaces.What it adds
Four pages under
docs/guides/operations-guide/mariadb/:backups, confirming a run succeeded, copying archives off the hosts, and
scheduling with a prune script.
and copies another, so an archive can record a binary log position belonging to a
different node and restore cleanly to the wrong state. How to tell whether a
deployment is exposed, the overlay that corrects it, and what to do about
archives taken before it.
increment, and reconciling against OVN, Ceph and the hypervisors afterwards.
The old sections gave both
mariadb-recoverycommands but delegated the restoreitself to the kolla-ansible manual, which documents the archive layout OSISM left
behind at 9.2.0.
What was verified, and how
agent working only from these pages — full backup, incremental backup, then a
destructive restore from the full plus one increment. Correctness was established
with a marker written between the full and the increment, so its survival proves
the increment was applied rather than merely that a restore happened. Verified on
each node directly rather than through the load balancer.
ordering bug an earlier revision had: it announced it was keeping a full because
an increment referenced it, then cut that increment in a later pass. The shipped
version removes the now-unreferenced full instead.
🤖 Generated with Claude Code