Bug fix 0715

[WhiredPlanck]

Pull request

Issue tracker

Fixes will automatically close the related issues

Fixes #1626
Fixes #1640
Fixes #1659
Fixes #1664

Feature

Describe features of this pull request

Code of conduct

• CONTRIBUTING

Code style

• make sytle-lint
• Conventional Commits

Build pass

• make debug

Manually test

• Done

Code Review

1. No wildcards import
2. Manual build and test pass
3. GitHub Action CI pass
4. At least one contributor review and approve
5. Merged clean without conflicts
6. PR will be merged by rebase upstream base

Daily build

Login and download artifact at https://github.com/osfans/trime/actions

Additional Info

[Bambooin]

Found two regressions on this patch:

1. On light theme, the number keyboard label are missing
2. On dark theme, all label of keyboard are missing

[WhiredPlanck]

Found two regressions on this patch:

1. On light theme, the number keyboard label are missing

2. On dark theme, all label of keyboard are missing

Gross, I'll fix soon.

[WhiredPlanck]

@Bambooin Re-push a fix.

[Bambooin]

The blocked regressions were fixed in the latest commit, thanks.

One small regression on click "主题" button in the keyboard, the heigth of first row is too large comparing with other rows.

[WhiredPlanck]

the heigth of first row is too large comparing with other rows.

I'm not quite clear. Could you post a screen recording?

[Bambooin]

Sure, here is the screenshot for the issue, the height of first row is too large than other rows which are too small to click.

[WhiredPlanck]

Sure, here is the screenshot for the issue, the height of first row is too large than other rows which are too small to click.

Oh, I see. This is a issue introduced by the last refactoring to theme system. I'll try to fix this in future PR.