Improve Theme Deserialization with Jackson#1675
Closed
WhiredPlanck wants to merge 6 commits into
Closed
Conversation
KotlinX Serialization (kaml) is nice, but it's too oriented to parse our themes. Although we have wrapped it with custom Config class, it slows down the performance. Jackson is a popular library to parse JSON, YAML and more, and it provides quite performance as KotlinX Serialization, and it can be very flexible to deal with complex data parsing.
WhiredPlanck
force-pushed
the
theme-deserialization
branch
from
June 25, 2025 20:13
f80119d to
7bbd9d4
Compare
Hope this can increase some performance.
WhiredPlanck
force-pushed
the
theme-deserialization
branch
from
June 26, 2025 04:01
7bbd9d4 to
8256ab5
Compare
Collaborator
Author
|
This PR is ready for review. @Bambooin |
Collaborator
|
App frozen in Android 15. |
Collaborator
Author
It may be normal for debug version because app is deserializing all deployed themes. Just wait. |
Collaborator
Author
|
@Bambooin But, I still want to complain: a theme system which needs to deploy to work is annoying. Do you have any idea with my suggestion about the WebView keyborad? |
Collaborator
|
Collaborator
Author
|
I build a release package by myself and it crashes with no end. This PR seems not able to be merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
Issue tracker
Fixes will automatically close the related issues
Fixes # N/A
Feature
Describe features of this pull request
KotlinX Serialization (kaml) is nice, but it's too oriented to parse our themes. Although we have wrapped it with custom Config class, it slows down the performance. Jackson is a popular library to parse JSON, YAML and more, and it provides quite performance as KotlinX Serialization, and it can be very flexible to deal with complex data parsing.
Code of conduct
Code style
make sytle-lintBuild pass
make debugManually test
Code Review
Daily build
Login and download artifact at https://github.com/osfans/trime/actions
Additional Info
Changes requires manual intervention
Users who use zero value like 0x0000 as black color value without quote must to modify it to be quoted or 0xAA000000. Otherwise some things will be transparent.