feat: add wrapper of native config parser#1668
Conversation
f696f50 to
df6b9c9
Compare
|
Found one crash with latest commit in Android 15. |
May you use the default theme then try again? |
|
After switching the theme from standard to default, no crash shows up anymore. Step to reprodue
|
In my test, for somehow, app will crash on first-time startup after install the new apk when initialize the theme. However, if you select the other theme or then just reselect the previous theme, everything is OK. It seems that this PR has nothing to do with the issue. It may cause by the Kotlin-made config parser, I will replace it with this native config parser in the future PR. |
df6b9c9 to
925354b
Compare
|
I polish the refctors again. So... if there is no problem else, I'd like to merge this PR first then fix the crash in other PR. |
|
Code style check failed on macOS. But I have nothing to do. |
582b474 to
f2cdea4
Compare
This can eliminate a lot of ugly code.
f2cdea4 to
6f297f1
Compare
|
@Bambooin Done. I replace the Kotlin-made config parser to native's one, and map the theme config to data classes. This can eliminate a lot of ugly code and make stronger code. |
|
The latest commit will cause Trime crash after clicking the icon immediately. |
|
@Bambooin Hm,it seems that native config parser can only be used when rime is ready, leading to make user waiting for keyboard show up. I think I should polish the Kotlin-made config parser. |
Pull request
Issue tracker
Fixes will automatically close the related issues
Fixes #1656
Feature
Describe features of this pull request
The yaml parser of Kotlin/Java is not powerful enough to deal with librime's style yaml config. So I bring back a wrapper of the native config api.
Code of conduct
Code style
make sytle-lintBuild pass
make debugManually test
Code Review
Daily build
Login and download artifact at https://github.com/osfans/trime/actions
Additional Info