test(git-ui): cover empty repository and empty history states (#1576)#1651
Merged
oscharko merged 1 commit intoJun 28, 2026
Conversation
The #1576 acceptance criterion "Empty repository and no-repository states guide users to clone or open a local repository" and its "empty states" verification gate were satisfied in production code (RepositoryListSearch and HistoryPane) but lacked dedicated regression tests. An acceptance audit of Epic #1571 confirmed the behaviour is correct yet untested. Add two GitClientWindow regression tests: - no-repository state renders the add-repository guidance and affordance - an initialized repository with zero commits renders the no-commits history guidance and omits the commit listbox No production behaviour changes; this closes the one evidence gap found during the Epic #1571 acceptance-criteria audit. Refs #1571 Refs #1576 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
oscharko
merged commit a89e609
into
feat/keiko-repository-centered-desktop-workflow
8 checks passed
53 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR closes the single evidence gap found during a full acceptance-criteria audit of Epic #1571 (Git Client: Repository-Centered Desktop Workflow).
The audit verified every Epic + child-issue acceptance criterion against the merged code on
feat/keiko-repository-centered-desktop-workflow(merge commitdb33a485). The implementation is genuine and complete; one criterion had correct production behaviour but no dedicated regression test:The two empty states are implemented in production code but were untested:
RepositoryListSearch.tsx:102-106— no-repository state: "No repositories yet. Add a repository to begin." + add-repository affordance.HistoryPane.tsx:93-100— zero-commit history state: "No commits yet. Make a commit to start history."Change
Adds two
GitClientWindowregression tests (test-only, no production behaviour change):Commit historylistbox.Acceptance-criteria mapping
Verification
npx vitest run …/git-client/GitClientWindow.test.tsx→ 74 passed (was 72).npx vitest run …/git-client(full dir) → 183 passed (was 181).eslint GitClientWindow.test.tsx --max-warnings=0→ clean.cimust pass on this PR head.Scope
Epic-scoped to #1571 / #1576. No unrelated refactors. No security/architecture/CSP/evidence gate changes.
Refs #1571
Refs #1576
🤖 Generated with Claude Code