[codex] Fix workspace synchronization#1544
Merged
Merged
Conversation
20a6c50 to
dc23534
Compare
dc23534 to
45238d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1540 by synchronizing the desktop workspace state across open Keiko clients.
Root Cause
The workspace hook hydrated and persisted windows/connections through browser-local
localStorage, but it did not subscribe to changes written by another tab. BecauselocalStorageis browser-local, a second browser also had no shared source of truth and could show the empty workspace while another browser had active windows.Changes
GET/PUT /api/workspace/state.useWorkspaceto:storageevents from other tabs in the same browser profile,Validation
npm run build:packagesnpm test --workspace @oscharko-dev/keiko-ui -- useWorkspace.keyboard.test.tsx workspace-persistence.test.tsnpm run typecheck --workspace @oscharko-dev/keiko-uinpx vitest run packages/keiko-server/src/routes.test.ts packages/keiko-server/src/server.test.tsnpx prettier --check packages/keiko-ui/src/app/components/desktop/hooks/useWorkspace.ts packages/keiko-ui/src/app/components/desktop/hooks/useWorkspace.keyboard.test.tsx packages/keiko-server/src/routes.ts packages/keiko-server/src/server.test.ts packages/keiko-server/src/workspace-state-handlers.ts