test(editor): repair baseline tab selector so dirty/recovery scenarios run (Refs #1377)

[oscharko]

Summary

Follow-up to the merged #1519 that lands two test-only commits the squash-merge raced past. PR #1519 was squash-merged from its first commit (d62cb464) before the post-open hardening commits synchronized, so the editor baseline matrix shipped on the feat branch with a tab selector that does not match the real DOM.

Refs #1377 (Parent Epic #1491)

Problem

tests/e2e/support/editorWorkspace.ts defined tab: ".ed-tab[role='tab']", but in the editor DOM the outer span.ed-tab carries data-dirty/active while role='tab' and data-tip/aria-selected live on the inner button.ed-tab-hit. As merged, three baseline scenarios that read the dirty state through that selector fail to find any element:

• e. dirty buffer marked in tab + status bar
• f. dirty-close guard dialog
• g. hot-exit recovery after reload

These are exactly the dirty-close and recovery behaviors named in Issue #1377 AC2, so the gate must be repaired for the acceptance criterion to hold.

Changes (test-infrastructure only)

• tests/e2e/support/editorWorkspace.ts: tab selector → .ed-tab (the dirty/active-bearing span; role='tab' is on the .ed-tab-hit it wraps).
• tests/e2e/editor-baseline-1377.spec.ts: tabFor locates the dirty span via .ed-tab:has(.ed-tab-hit[data-tip=...]); adds an explicit dirty-close-dialog aria-labelledby assertion (adversarial a11y-review note); corrects the scenario-j comment — Alt+ArrowRight reorders the active tab rather than switching selection.

No product code, no CI workflow, no dependency, and no other spec is changed.

Verification

npm run test:e2e:editor-baseline-1377   -> 10/10 passed against the real packaged app (rebuilt on current feat HEAD)
npx eslint <spec> <helper>              -> PASS
npx prettier --check <spec> <helper>    -> PASS

The matrix now passes all ten scenarios, including e/f/g, on the current feat base (which also carries the #1520 release-smoke fix).

🤖 Generated with Claude Code