Conversation
Stabilize workspace card connections by confirming valid target windows in the workspace capture phase and adding a regression test for target child controls.
Prepare Keiko 0.1.6 with enterprise TLS system CA fallback for internal model gateways while preserving TLS verification.
There was a problem hiding this comment.
Pull request overview
Promotes Keiko release 0.1.6 from dev to main, including the internal-gateway TLS trust-chain retry improvements and the workspace card connection stabilization.
Changes:
- Bump root/UI/SDK/harness versions to
0.1.6(including lockfiles). - Improve workspace “click-to-connect” reliability by confirming connections from a workspace-level capture handler and tagging window roots with
data-window-id. - Expand gateway CA fallback to include additional Node/system trust sources and broaden retry gating to recoverable TLS trust-chain errors, with accompanying tests.
Reviewed changes
Copilot reviewed 11 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ui/package.json | Bump UI package version to 0.1.6. |
| ui/package-lock.json | Align UI lockfile version metadata to 0.1.6. |
| ui/app/components/desktop/Workspace.tsx | Confirm connects via onPointerDownCapture using data-window-id to handle stopped bubbling. |
| ui/app/components/desktop/Workspace.test.tsx | Add regression test ensuring connect confirmation works even when a child stops bubbling. |
| ui/app/components/desktop/windows/WindowFrame.tsx | Add data-window-id attribute on window root for capture-based targeting. |
| ui/app/components/desktop/hooks/workspaceActions.ts | Keep connectingRef in sync and focus the target window after a successful confirmConnect. |
| ui/app/components/desktop/hooks/useWorkspace.ts | Wire focus into connect action creation. |
| tests/gateway/http.test.ts | Add tests for recoverable TLS error gating and for the expanded gateway CA bundle behavior. |
| src/sdk/index.ts | Bump SDK_VERSION to 0.1.6. |
| src/harness/session.ts | Bump HARNESS_VERSION to 0.1.6. |
| src/gateway/http.ts | Add recoverable TLS trust error detection + expanded CA bundle composition; use it for HTTPS fallback retries. |
| package.json | Bump package version to 0.1.6. |
| package-lock.json | Align root lockfile version metadata to 0.1.6. |
Files not reviewed (1)
- ui/package-lock.json: Language not supported
Comments suppressed due to low confidence (1)
ui/app/components/desktop/windows/WindowFrame.tsx:343
- When connState is "valid", this handler calls api.confirmConnect(win.id, e) and then immediately calls api.focus(win.id). confirmConnect already calls focus(toId) (and stops propagation), so this results in two focus() calls for the same click, unnecessarily incrementing the z-counter twice and causing an extra state update/re-render.
onPointerDown={(e) => {
if (connState === "valid") api.confirmConnect(win.id, e);
api.focus(win.id);
}}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release Keiko
0.1.6fromdevintomain.This includes the verified system-CA TLS fix for internal model gateways and the previously merged workspace card connection stabilization from
dev.Refs n/a
Scope
devtomainfor release publication.Product Impact
Verification
Required:
Local verification:
Select only what applies:
npm run prepackandnpm pack --dry-run.Not applicable rationale:
Review And Closure
Resolves #<issue_number>only when this PR should close the issue.Risk Notes
Release integration risk only.
devhas already passed the full PR gate for the code changes.mainmust pass CI before npm publication.