Skip to content

fix(deps): resolve open security advisories - #161

Merged
dillonstreator merged 1 commit into
mainfrom
claude/security-issues-resolution-057f04
Nov 6, 2026
Merged

dillonstreator merged 1 commit into
mainfrom
claude/security-issues-resolution-057f04

Conversation

@dillonstreator

@dillonstreator dillonstreator commented Nov 6, 2026 •

Copy link
Copy Markdown
Member

Summary

Resolves 21 of the 22 open Dependabot alerts. pnpm audit goes from 22 findings (1 critical, 11 high, 6 moderate, 4 low) to 1 low. Code scanning and secret scanning have no open alerts.

Package Before After Alerts Reach Change
seroval 1.5.6 1.7.7 1 critical, 4 high, 1 medium Web runtime, via @tanstack/router-core Override
zod 4.4.3 4.6.7 1 high Runtime in all packages Declared range raised to ^4.6.6
node-forge 1.4.0 1.4.3 6 high, 3 medium, 3 low Dev only, via vite-plugin-web-extension Override
glob 10.5.0, 13.0.6 14.0.3 1 medium Server runtime via @fastify/static, otherwise dev Override
minimatch 9.0.9, 10.2.5 11.0.4 1 medium Mostly dev, also through glob Override

seroval-plugins moves with seroval because the two are released in lockstep. The new glob selector replaces the two older, narrower glob overrides. A changeset is included because the published packages' zod range changed.

Review notes

  • Major-version overrides: glob and minimatch are forced past what their dependents declare (Jest, @fastify/static, typescript-eslint, nodemon), because the advisories have no fix on the older majors. Tests, lint and the Swagger check below cover these paths, but these are the overrides to revisit if an upstream update misbehaves.
  • zod minor update: this crosses several minor versions and affects request validation on the server. Typecheck and the test suites pass.

Not resolved

deepmerge (GHSA-gcqx-w48m-w2h4, low) has no patched release; 4.3.1 is the latest on npm, although pnpm audit lists >=4.3.2. It is only reached through jest-config, which merges local Jest config and presets, so it isn't exposed to untrusted input. The alert stays open until upstream ships a fix or it is dismissed.

Testing

  • pnpm lint, pnpm typecheck, pnpm build, pnpm format:check
  • Unit tests: core 47, cli 15, extension 14, server 8, web 6
  • pnpm test:e2e: 5 passed, including the production CSP
  • Started the built server and confirmed Swagger UI's static assets return 200 on glob 14
  • Compared against baseline main: the same 7 non-blocking blocked eval CSP messages appear there, so they are not new

Jest reports "No tests found" on Windows when the checkout path contains a dot-directory such as .claude/worktrees. Baseline main fails the same way, so the Jest suites were run from a checkout outside that path. This PR does not change that behaviour.

Move vulnerable transitive dependencies to patched versions using the
existing pnpm overrides, and raise the declared zod floor to 4.6.6 so
consumers of the published packages cannot resolve an affected version.

deepmerge is unchanged because no patched release exists upstream.
@dillonstreator
dillonstreator merged commit 012b06a into main Nov 6, 2026
8 checks passed
@dillonstreator
dillonstreator deleted the claude/security-issues-resolution-057f04 branch November 6, 2026 22:10
@github-actions github-actions Bot mentioned this pull request Nov 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant