Repository navigation
fix(deps): resolve open security advisories - #161
Merged
Merged
Conversation
Move vulnerable transitive dependencies to patched versions using the existing pnpm overrides, and raise the declared zod floor to 4.6.6 so consumers of the published packages cannot resolve an affected version. deepmerge is unchanged because no patched release exists upstream.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves 21 of the 22 open Dependabot alerts.
pnpm auditgoes from 22 findings (1 critical, 11 high, 6 moderate, 4 low) to 1 low. Code scanning and secret scanning have no open alerts.seroval@tanstack/router-corezod^4.6.6node-forgevite-plugin-web-extensionglob@fastify/static, otherwise devminimatchglobseroval-pluginsmoves withserovalbecause the two are released in lockstep. The newglobselector replaces the two older, narrowergloboverrides. A changeset is included because the published packages'zodrange changed.Review notes
globandminimatchare forced past what their dependents declare (Jest,@fastify/static,typescript-eslint,nodemon), because the advisories have no fix on the older majors. Tests, lint and the Swagger check below cover these paths, but these are the overrides to revisit if an upstream update misbehaves.zodminor update: this crosses several minor versions and affects request validation on the server. Typecheck and the test suites pass.Not resolved
deepmerge(GHSA-gcqx-w48m-w2h4, low) has no patched release; 4.3.1 is the latest on npm, althoughpnpm auditlists>=4.3.2. It is only reached throughjest-config, which merges local Jest config and presets, so it isn't exposed to untrusted input. The alert stays open until upstream ships a fix or it is dismissed.Testing
pnpm lint,pnpm typecheck,pnpm build,pnpm format:checkpnpm test:e2e: 5 passed, including the production CSPglob14main: the same 7 non-blockingblocked evalCSP messages appear there, so they are not newJest reports "No tests found" on Windows when the checkout path contains a dot-directory such as
.claude/worktrees. Baselinemainfails the same way, so the Jest suites were run from a checkout outside that path. This PR does not change that behaviour.