Units conversion bug fix#595
Open
jroman-ak wants to merge 4 commits into
Open
Conversation
jroman-ak
force-pushed
the
units-conversion-bug-fix
branch
from
358e29d to
826edba
Compare
jroman-ak
force-pushed
the
units-conversion-bug-fix
branch
from
3e5ec88 to
865e429
Compare
…le unit types Signed-off-by: Yulian Lyubomirov Cenov <ycenov@arfima.com>
Signed-off-by: Juan Roman <jroman@arfimaconsulting.com>
Signed-off-by: Juan Roman <jroman@arfimaconsulting.com>
Signed-off-by: Juan Roman <jroman@arfimaconsulting.com>
jroman-ak
force-pushed
the
units-conversion-bug-fix
branch
from
865e429 to
408ca63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous unit conversion logic only skipped conversion if the source units where "default", i.e. in the absence of units in the hazard dataset. The new logic allows to define a set of preregistered adimensional units, such as "index", for which unit conversion should also be skipped. This is necessary for hazards with adimensional indicators such as susceptability.
Co-authored-by: Yulian Lyubomirov Cenov ycenov@arfima.com
Signed-off-by: Juan Román Roche jroman@arfimaconsulting.com