fix: pass path directly to toml.load() instead of opening file#31
Merged
orsinium merged 1 commit intoApr 13, 2026
Merged
Conversation
The fallback path for the `toml` library opened the file in binary mode
with an encoding argument (`open('rb', encoding='utf8')`), which raises
a ValueError since binary mode doesn't accept encoding. Rather than
fixing the open mode, pass the path directly to `toml.load()` which
accepts file paths natively and handles encoding internally.
✅ Deploy Preview for mypy-baseline ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
|
thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fallback path for the
tomllibrary opened the file in binary modewith an encoding argument (
open('rb', encoding='utf8')), which raisesa ValueError since binary mode doesn't accept encoding. Rather than
fixing the open mode, pass the path directly to
toml.load()whichaccepts file paths natively and handles encoding internally.