fix(ci): drop stray /v2 suffix from VITE_UFABC_PARSER_URL#538
Open
Joabesv wants to merge 1 commit into
Open
Conversation
The connector's own request paths already prefix /v2 (e.g. /v2/components/enrolled in packages/connectors/src/ufabc-parser.ts), so the base URL needs to be bare. This was producing double /v2/v2/... paths in every request once the Turbo env-passthrough fix let the value actually reach the build. apps/core's own UFABC_PARSER_URL and the local extension .env both already use the bare host, confirming this was the wrong value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VITE_UFABC_PARSER_URLwas set tohttps://ufabc-parser.com/v2, but the connector's own request paths already prefix/v2(e.g./v2/components/enrolledinpackages/connectors/src/ufabc-parser.ts), producing double/v2/v2/...URLs — reported live in prod ashttps://ufabc-parser.com/v2/v2/components/enrolled.apps/core/.env.prod(UFABC_PARSER_URL="https://ufabc-parser.com") and the local extension.env(http://localhost:5001, no/v2).Test plan
https://ufabc-parser.comwith no/v2suffix, while/v2/components/enrolledetc. still compose correctly from the request-path side