Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions ojdbc-provider-azure/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -219,11 +219,13 @@ The user can provide an optional parameter `AUTHENTICATION` (case-ignored) which
<td><b>AZURE_CLIENT_ID</b> (only required for user assigned)</td>
</tr>
<tr>
<td rowspan="2"><b>AZURE_INTERACTIVE</b></td>
<td rowspan="2">InteractiveBrowserCredential</td>
<td><b>AZURE_CLIENT_ID</b></td>
<td><b>AZURE_REDIRECT_URL</b></td>
<td rowspan="3"><b>AZURE_INTERACTIVE</b></td>
<td rowspan="3">InteractiveBrowserCredential</td>
<td rowspan="3">&nbsp;</td>
<td><b>AZURE_TENANT_ID</b></td>
</tr>
<tr><td><b>AZURE_CLIENT_ID</b></td></tr>
<tr><td><b>AZURE_REDIRECT_URL</b></td></tr>
</tbody>
</table>

Expand Down Expand Up @@ -732,7 +734,7 @@ common set of parameters.
<a href="https://docs.microsoft.com/en-us/azure/active-directory/develop/reply-url">
Redirect URL
</a>
for <code>authentication-method=interactive</code>
for <code>authenticationMethod=interactive</code>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This is a very good correction :)

</td>
<td>
A URL of the form <code>http://localhost[:port-number]</code> is accepted.
Expand Down Expand Up @@ -813,7 +815,8 @@ A browser link is output to the standard output stream.
<dt>interactive</dt>
<dd>
Authenticate interactively by logging in to a cloud account with your
default web browser. The browser window is opened automatically.
default web browser. The browser window is opened automatically. The optional
<code>tenantId</code> parameter may be configured to target a specific tenant.
</dd>
<dt>auto-detect</dt>
<dd>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -202,15 +202,15 @@ private static TokenCredential defaultCredentials(ParameterSet parameterSet) {

/**
* Returns credentials for interactive authentication in a web browser.
* @param parameterSet Configures the request with a client ID (optional), and
* redirect URL (required).
* @param parameterSet Configures the request with optional tenant ID, client ID,
* and redirect URL.
* @return Credentials for interactive authentication
* //throws //TODO: What does this throw?
*/
private static InteractiveBrowserCredential interactiveCredentials(
ParameterSet parameterSet) {
return new InteractiveBrowserCredentialBuilder()
.clientId(parameterSet.getOptional(CLIENT_ID))
.tenantId(parameterSet.getOptional(TENANT_ID))
.redirectUrl(parameterSet.getOptional(REDIRECT_URL))
.build();
}
Expand Down