Skip to content

Added basic type checks in java.lsp.server config change listeners#607

Merged
sid-srini merged 1 commit into
oracle:26.0.1from
sid-srini:lsp-server-config-listeners-null-check
Jun 16, 2026
Merged

Added basic type checks in java.lsp.server config change listeners#607
sid-srini merged 1 commit into
oracle:26.0.1from
sid-srini:lsp-server-config-listeners-null-check

Conversation

@sid-srini

Copy link
Copy Markdown
Member

Backports netbeans PR 9369.

  • Added checks for null and required JsonElement type in the registered config change listeners in WorkspaceService.
  • Included a check for blank input defaultPlatformOverride in AbstractJavaPlatformProviderOverride to avoid expensive initialization in such cases.

This fixes issues like "IOException: Invalid J2SE platform" when jdk.project.jdkhome is set to "" in settings.json.

Backports netbeans PR 9369.
- Added checks for null and required JsonElement type in the
  registered config change listeners in WorkspaceService.
- Included a check for blank input defaultPlatformOverride in
  AbstractJavaPlatformProviderOverride to avoid expensive
  initialization in such cases.

This fixes issues like "IOException: Invalid J2SE platform" when
`jdk.project.jdkhome` is set to `""` in settings.json.
@sid-srini sid-srini added this to the JVSC 26.0.1 milestone Jun 5, 2026
@sid-srini sid-srini requested a review from Achal1607 June 5, 2026 10:19
@oracle-contributor-agreement oracle-contributor-agreement Bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jun 5, 2026

@Achal1607 Achal1607 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @sid-srini

@sid-srini sid-srini merged commit 8ca233c into oracle:26.0.1 Jun 16, 2026
2 checks passed
@sid-srini sid-srini deleted the lsp-server-config-listeners-null-check branch June 16, 2026 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants