Fixed jdkHome config value handler fallback to env vars#606
Merged
sid-srini merged 1 commit intoJun 5, 2026
Merged
Conversation
Fixed handler.ts:jdkHomeValueHandler() to have the promise return the fallback env vars JDK_HOME or JAVA_HOME when no config value is defined. - The config getter returns the default value i.e. null, in such a case. - Thus, the defaultValue parameter cannot be used, since the vscode config getter returns the default value defined in package.json, causing the value to not be `undefined`. - So, a `then()` clause on the promise is needed to check for `null` or `undefined` value, and fallback to the env vars, if so.
oracle-contributor-agreement
Bot
added
the
OCA Verified
Achal1607
approved these changes
Jun 5, 2026
Achal1607
left a comment
Achal1607
left a comment
Member
There was a problem hiding this comment.
Hey, @sid-srini thanks for identifying it. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed
handler.ts:jdkHomeValueHandler()to have the promise return the fallback env varsJDK_HOMEorJAVA_HOMEwhen no config value is defined.null, in such a case.defaultValueparameter cannot be used, since the vscode config getter returns the default value defined in package.json, causing the value to not beundefined.then()clause on the promise is needed to check fornullorundefinedvalue, and fallback to the env vars, if so.