Skip to content

Fixing test related issues#432

Merged
sid-srini merged 1 commit into
oracle:mainfrom
subhash-arabhi:launch-config-update
Aug 22, 2025
Merged

Fixing test related issues#432
sid-srini merged 1 commit into
oracle:mainfrom
subhash-arabhi:launch-config-update

Conversation

@subhash-arabhi

@subhash-arabhi subhash-arabhi commented Jun 12, 2025

Copy link
Copy Markdown
Contributor

Fixing the below issues -

Sending right project value - #431
Using testRun value - #353
Duplication of VMArgs -
Removal of picking up launch config from vscode - #347

Nb PR - apache/netbeans#8470

@oracle-contributor-agreement oracle-contributor-agreement Bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jun 12, 2025
@subhash-arabhi
subhash-arabhi force-pushed the launch-config-update branch from bdf1067 to 6ee3220 Compare July 8, 2025 22:32
sid-srini
sid-srini previously approved these changes Jul 9, 2025

@sid-srini sid-srini left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @subhash-arabhi. LGTM 👍

Comment thread vscode/src/commands/debug.ts Outdated
@sid-srini
sid-srini self-requested a review July 9, 2025 15:14
@subhash-arabhi
subhash-arabhi force-pushed the launch-config-update branch from 0d6b83c to 9ef1d82 Compare July 9, 2025 15:24
sid-srini
sid-srini previously approved these changes Jul 10, 2025
@Achal1607 Achal1607 added this to the JVSC 24.1.1 milestone Jul 15, 2025
Fixing test related issues

Signed-off-by: Subhash Arabhi <subhashsubbu636@gmail.com>
@sid-srini
sid-srini force-pushed the launch-config-update branch from d454282 to 1b73b68 Compare August 18, 2025 06:41

@sid-srini sid-srini left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased commit. LGTM 👍

@sid-srini
sid-srini requested a review from Achal1607 August 18, 2025 06:43

@Achal1607 Achal1607 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks

@sid-srini
sid-srini merged commit 3cc1697 into oracle:main Aug 22, 2025
2 checks passed
@sid-srini sid-srini linked an issue Sep 29, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test run on a single file runs the whole suite

3 participants