Add image lookup#281
Draft
shyamradhakrishnan wants to merge 16 commits into
Draft
Conversation
oracle-contributor-agreement
Bot
added
the
OCA Verified
Contributor
Author
|
unit test |
joekr
approved these changes
Jun 26, 2023
| if len(response.Items) == 0 { | ||
| return nil, errors.New(fmt.Sprintf("could not lookup image from lookup parameters")) | ||
| } | ||
| imageId = *response.Items[0].Id |
Member
There was a problem hiding this comment.
add a quick todo maybe for "pagination"?
Contributor
Author
There was a problem hiding this comment.
we have limit in the request to one as we really need the latest one, hence we sort by time created. I hope this makes sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add ability to lookup images.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #280