[AI-FSSDK] [FSSDK-12839] Add no-op regression test for non-holdout decision id normalization#647
Closed
jaeopt wants to merge 1 commit into
Closed
[AI-FSSDK] [FSSDK-12839] Add no-op regression test for non-holdout decision id normalization#647jaeopt wants to merge 1 commit into
jaeopt wants to merge 1 commit into
Conversation
Contributor
Author
|
TESTING ONLY |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Locks in the byte-equivalent no-op behavior of decision-event id normalization for non-holdout decisions (experiments, feature tests, rollouts). The existing holdout tests cover the fallback path; this regression covers the happy path so a future refactor cannot silently start substituting valid IDs.
Changes
normalizeDecisionIdspasses valid numericcampaign_idandvariation_idthrough unchanged, and thatcampaign_iddoes not collapse toexperiment_idwhen the raw value is already valid.Jira Ticket
FSSDK-12839