fix: prevent uv.lock/pyproject.toml clobbering in Dockerfile COPY#9490
Open
fatih-acar wants to merge 1 commit into
Open
fix: prevent uv.lock/pyproject.toml clobbering in Dockerfile COPY#9490fatih-acar wants to merge 1 commit into
fatih-acar wants to merge 1 commit into
Conversation
The single multi-source COPY collapsed every source to its basename in /source/, so python_testcontainers' uv.lock and pyproject.toml overwrote the root workspace files. The dependency-cache layer then resolved against the testcontainers project instead of infrahub-server, defeating its purpose. Split into per-destination COPY statements that preserve the directory structure. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
No issues found across 1 file
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Shadow auto-approve: would auto-approve. This Dockerfile change corrects a multi-source COPY that was incorrectly collapsing files into a single directory, by splitting it into per-destination statements to preserve the directory structure and ensure the dependency cache resolves against the correct workspace.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The single multi-source COPY collapsed every source to its basename in /source/, so python_testcontainers' uv.lock and pyproject.toml overwrote the root workspace files. The dependency-cache layer then resolved against the testcontainers project instead of infrahub-server, defeating its purpose. Split into per-destination COPY statements that preserve the directory structure.
Summary by cubic
Fix Dockerfile COPY that collapsed multiple sources into /source/ and overwrote the root uv.lock and pyproject.toml with the
python_testcontainersversions. Use per-destination COPY to preserve directory structure, so the dependency cache resolves against theinfrahub-serverworkspace instead of the testcontainers project.Written for commit 738ab6b. Summary will update on new commits.