Skip to content

fix: prevent uv.lock/pyproject.toml clobbering in Dockerfile COPY#9490

Open
fatih-acar wants to merge 1 commit into
stablefrom
fac-fix-dockerfile-uv-lock-copy
Open

fix: prevent uv.lock/pyproject.toml clobbering in Dockerfile COPY#9490
fatih-acar wants to merge 1 commit into
stablefrom
fac-fix-dockerfile-uv-lock-copy

Conversation

@fatih-acar

@fatih-acar fatih-acar commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

The single multi-source COPY collapsed every source to its basename in /source/, so python_testcontainers' uv.lock and pyproject.toml overwrote the root workspace files. The dependency-cache layer then resolved against the testcontainers project instead of infrahub-server, defeating its purpose. Split into per-destination COPY statements that preserve the directory structure.


Summary by cubic

Fix Dockerfile COPY that collapsed multiple sources into /source/ and overwrote the root uv.lock and pyproject.toml with the python_testcontainers versions. Use per-destination COPY to preserve directory structure, so the dependency cache resolves against the infrahub-server workspace instead of the testcontainers project.

Written for commit 738ab6b. Summary will update on new commits.

Review in cubic

The single multi-source COPY collapsed every source to its basename in
/source/, so python_testcontainers' uv.lock and pyproject.toml overwrote
the root workspace files. The dependency-cache layer then resolved
against the testcontainers project instead of infrahub-server, defeating
its purpose. Split into per-destination COPY statements that preserve the
directory structure.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Shadow auto-approve: would auto-approve. This Dockerfile change corrects a multi-source COPY that was incorrectly collapsing files into a single directory, by splitting it into per-destination statements to preserve the directory structure and ensure the dependency cache resolves against the correct workspace.

Re-trigger cubic

@codspeed-hq

codspeed-hq Bot commented Jun 7, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 12 untouched benchmarks


Comparing fac-fix-dockerfile-uv-lock-copy (738ab6b) with stable (2a1cff7)1

Open in CodSpeed

Footnotes

  1. No successful run was found on stable (9d65300) during the generation of this report, so 2a1cff7 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant