Merge stable into develop#1077
Open
infrahub-github-bot-app[bot] wants to merge 3 commits into
Open
Conversation
GitRepoManager.initialize_repo() checked for `.git` with `.is_dir()`, which misses git worktrees (`.git` is a file containing `gitdir: ...`). The existing-repo branch was skipped and `Repo.init` then crashed with `FileExistsError` trying to mkdir the gitlink file. This made `infrahubctl transform` (and any other CLI relying on branch auto-detection) unusable from a worktree. Switch the check to `.exists()` — dulwich's `Repo(path)` already resolves the gitlink to the real controldir, and `porcelain.active_branch` returns the worktree's branch correctly.
fix(repository): detect existing repo when .git is a worktree gitlink
Deploying infrahub-sdk-python with
|
| Latest commit: |
05ac997
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://291fdfe7.infrahub-sdk-python.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging stable into develop after merging pull request #1029.
Summary by cubic
Prevent opaque backend errors during upsert by rejecting
save(allow_upsert=True)when the HFID depends on an unresolvedCoreNumberPoolattribute, raising a clearValidationError. Also detect.gitgitlinks in worktrees so existing repos open correctly instead of re-initializing and crashing.ValidationError; addAttribute.is_unresolved_pool_attributeplus tests and docs outlining alternatives..exists()instead of.is_dir()for.gitinGitRepoManager.initialize_repoto support worktrees; add unit test.Written for commit 05ac997. Summary will update on new commits.