feat(infrahub): wire serviceAccount configuration into pod specs#64
Merged
Conversation
The infrahub-helm.serviceAccountName helper existed but was never used: there was no serviceAccount block in values, no ServiceAccount template, and no pod spec referencing it. - add top-level serviceAccount values (create, name, annotations) - add templates/serviceaccount.yaml rendered when create is true - set serviceAccountName on all pod specs (server, task-worker, upgrade job, demo-data job, emma), omitted when unset so default installs render unchanged - remove the orphaned serviceAccountName helper from infrahub-enterprise Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
infrahub-helm.serviceAccountNamehelper existed in theinfrahubchart but was completely orphaned: no top-levelserviceAccountblock in values, noServiceAccounttemplate, and no pod spec referencing it — so configuring a service account name silently did nothing.infrahub (4.21.6 → 4.22.0)
serviceAccountvalues block (create,name,annotations), mirroring the already-wiredinfrahub-backupcharttemplates/serviceaccount.yaml, rendered whenserviceAccount.create=true(supports annotations, e.g. for IRSA/Workload Identity)serviceAccountNameinto all 5 pod specs (server, task-worker, upgrade job, demo-data job, emma) viawith, so the field is omitted when unset — default installs render byte-identical to before (no rollout on upgrade)prefectTagdoc entry)infrahub-enterprise (4.7.6 → 4.8.0)
infrahub-enterprise-helm.serviceAccountNamehelper (dead code — workloads come from theinfrahubdependency)infrahubdependency pin to 4.22.0Behavior
serviceAccountNamerendered (unchanged manifests)serviceAccount.create=trueServiceAccountcreated, all 5 pods reference itserviceAccount.name=my-sa,create=falseTest plan
helm lintpasses for both chartshelm templateverified for the three configurations above🤖 Generated with Claude Code