[XLA:GPU] Port VMM allocator allocations to records#44224
Draft
shawnwang18 wants to merge 1 commit into
Draft
Conversation
shawnwang18
force-pushed
the
pr4_vmm_allocator_record_model
branch
from
fdf77c2 to
5e00368
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary of Changes
Ports allocator-address ownership in DeviceAddressVmmAllocator to AllocationRecord. Allocate(), mapped Allocate(), Deallocate(), pending allocator deallocation, reuse, and allocator-address getters now use record-backed state. Reservation aliases remain on the existing ReservationMapping maps for the next slice.
🎯 Justification
This isolates the allocator-address state migration from the reservation-alias migration, keeping each review focused and preserving the existing external behavior.
🚀 Kind of Contribution
♻️ Cleanup
📊 Benchmark (for Performance Improvements)
N/A.
🧪 Unit Tests:
Not run locally. Intended validation:
bazel build //xla/stream_executor:device_address_vmm_allocator //xla/stream_executor/cuda:cuda_device_address_vmm_allocatorandbazel test //xla/stream_executor/cuda:cuda_device_address_vmm_allocator_test.🧪 Execution Tests:
Not run locally.