fix discarded-qualifiers warnings with GCC 16+#158
Open
graysky2 wants to merge 1 commit into
Open
Conversation
strpbrk() returns char * even when passed a const char *, a known C standard wart. Explicitly cast the return value to char * at all nine call sites to satisfy -Werror=discarded-qualifiers Signed-off-by: John Audia <therealgraysky@proton.me>
graysky2
added a commit
to graysky2/openwrt
that referenced
this pull request
May 26, 2026
Add pending openwrt/odhcp6c#158 This is needed for openwrt#23194 Signed-off-by: John Audia <therealgraysky@proton.me>
|
Duplicate of #156? |
Author
|
Claude thinks this PR is a better approach:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
strpbrk() returns char * even when passed a const char *, a known C standard wart. Explicitly cast the return value to char * at all nine call sites to satisfy -Werror=discarded-qualifiers