Carpool bound access egress routing cost

[hakoncarlsen]

Summary

Bounds the cost of carpool access/egress street routing: each driver leg's search tree is sized from its routed travel duration plus the feasible detour, Fixes a bug where viable passenger drop off and pickup locations were filtered out by the BeelineEstimator estimator. Put's a hard limit on the maximum length of carpooling trips of 2.5 hours because of scalability issues, this might have to be improved in the future, but for now we need some way of avoiding that bad client data poisons the entire feed.

Unit tests

Write a few words on how the new code is tested.

• Were unit tests added/updated?

Yes

• Was any manual verification done?

Yes

• Any observations on changes to performance?

It solves some of the scalability problems of access/egress for carpooling. Now a single carpooling trip which is very long, either because of client errors or because it actually is very long cannot make the module churn until timeout.

• Was the code designed so it is unit testable?

Yes

• Were any tests applied to the smallest appropriate unit?

Yes

• Do all tests
  pass the continuous integration service
  ?

Yes

Documentation

• Have you added documentation in code covering design and rationale behind the code?

Yes

• Were all non-trivial public classes and methods documented with Javadoc?

Yes

• Were any new configuration options added? If so were the tables in
  the configuration documentation updated?

no

[codecov]

Codecov Report

❌ Patch coverage is 84.12698% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.09%. Comparing base (bdec812) to head (7e453db).

Files with missing lines	Patch %	Lines
...t/carpooling/service/DefaultCarpoolingService.java	80.82%	11 Missing and 3 partials ⚠️
...ner/ext/carpooling/routing/InsertionEvaluator.java	40.00%	4 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             dev-2.x    #7732   +/-   ##
==========================================
  Coverage      74.08%   74.09%           
- Complexity     21941    21971   +30     
==========================================
  Files           2434     2434           
  Lines          86135    86229   +94     
  Branches        8573     8590   +17     
==========================================
+ Hits           63817    63895   +78     
- Misses         19282    19295   +13     
- Partials        3036     3039    +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.