Master submodule update 06 09#4186
Conversation
Update to openshift/ovn-kubernetes@e9295c0 This commit was generated using hack/update_submodules.sh
Update to openshift/containernetworking-plugins@d6f7395 This commit was generated using hack/update_submodules.sh
Update to openshift/kubernetes@d8d517e This commit was generated using hack/update_submodules.sh
This commit was generated using hack/update_submodules.sh
This commit was generated using hack/update_submodules.sh
Update to openshift/cloud-provider-aws@d5b48e8 This commit was generated using hack/update_submodules.sh
📝 WalkthroughWalkthroughThis PR updates pinned versions across the Windows Machine Config Operator dependency tree. The changes encompass the kubelet build-time Git revision, OpenShift platform libraries, go-openapi tooling modules, Kubernetes OpenAPI machinery, and three key infrastructure submodules: cloud-provider-aws, containernetworking-plugins, and ovn-kubernetes. Each dependency shift moves to a more recent commit or release, bringing transitive updates to build outputs and runtime behavior across Windows and Linux orchestration paths. Suggested reviewers
🚥 Pre-merge checks | ✅ 17 | ❌ 3❌ Failed checks (2 warnings, 1 inconclusive)
✅ Passed checks (17 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jrvaldes The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@go.mod`:
- Around line 67-68: Verify compatibility of the indirect go-openapi bumps by
running the project's OpenAPI/schema checks: ensure the upgrade of
github.com/go-openapi/jsonpointer and github.com/go-openapi/jsonreference
doesn't change generated JSON names by exercising the swagger toolchain that
pulls in swag/jsonname (check swag v0.26.x behavior); run the standard
verification target (e.g., make verify) and inspect any diffs in generated
OpenAPI specs or schema name mappings (pay special attention to swag/jsonname
behavior and k8s.io/kube-openapi vendored usage), and if regressions appear, pin
or update swag/jsonname usage or adjust generation code to restore previous json
name behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: ec8775e0-49ad-4ace-adc5-13b727f99805
⛔ Files ignored due to path filters (57)
go.sumis excluded by!**/*.sum,!go.sumvendor/github.com/go-openapi/jsonpointer/.cliff.tomlis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/jsonpointer/.gitignoreis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/jsonpointer/CONTRIBUTORS.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/jsonpointer/NOTICEis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/jsonpointer/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/jsonpointer/errors.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/jsonpointer/ifaces.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/jsonpointer/options.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/jsonpointer/pointer.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/jsonreference/.gitignoreis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/jsonreference/CONTRIBUTORS.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/jsonreference/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/swag/jsonname/go_name_provider.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/swag/jsonname/ifaces.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/go-openapi/swag/jsonname/name_provider.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/api/config/v1/types_tlssecurityprofile.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/api/config/v1/zz_generated.deepcopy.gois excluded by!vendor/**,!**/vendor/**,!**/zz_generated.*.go,!**/zz_generated*vendor/github.com/openshift/api/config/v1/zz_generated.featuregated-crd-manifests.yamlis excluded by!vendor/**,!**/vendor/**,!**/zz_generated*vendor/github.com/openshift/api/config/v1/zz_generated.swagger_doc_generated.gois excluded by!vendor/**,!**/vendor/**,!**/zz_generated.*.go,!**/zz_generated*vendor/github.com/openshift/api/config/v1alpha1/types_cluster_monitoring.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/api/config/v1alpha1/zz_generated.deepcopy.gois excluded by!vendor/**,!**/vendor/**,!**/zz_generated.*.go,!**/zz_generated*vendor/github.com/openshift/api/config/v1alpha1/zz_generated.swagger_doc_generated.gois excluded by!vendor/**,!**/vendor/**,!**/zz_generated.*.go,!**/zz_generated*vendor/github.com/openshift/api/machineconfiguration/v1/register.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/api/machineconfiguration/v1/types.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/api/machineconfiguration/v1/types_osimagestream.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/api/machineconfiguration/v1/zz_generated.deepcopy.gois excluded by!vendor/**,!**/vendor/**,!**/zz_generated.*.go,!**/zz_generated*vendor/github.com/openshift/api/machineconfiguration/v1/zz_generated.featuregated-crd-manifests.yamlis excluded by!vendor/**,!**/vendor/**,!**/zz_generated*vendor/github.com/openshift/api/machineconfiguration/v1/zz_generated.swagger_doc_generated.gois excluded by!vendor/**,!**/vendor/**,!**/zz_generated.*.go,!**/zz_generated*vendor/github.com/openshift/api/operator/v1/types_etcd.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/api/operator/v1/zz_generated.featuregated-crd-manifests.yamlis excluded by!vendor/**,!**/vendor/**,!**/zz_generated*vendor/github.com/openshift/api/operator/v1/zz_generated.swagger_doc_generated.gois excluded by!vendor/**,!**/vendor/**,!**/zz_generated.*.go,!**/zz_generated*vendor/github.com/openshift/client-go/config/applyconfigurations/config/v1/clientcredentialconfig.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/client-go/config/applyconfigurations/config/v1/clientsecretsecretreference.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/client-go/config/applyconfigurations/config/v1/customtlsprofile.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/client-go/config/applyconfigurations/config/v1/externalclaimssource.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/client-go/config/applyconfigurations/config/v1/externalsourceauthentication.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/client-go/config/applyconfigurations/config/v1/externalsourcecertificateauthorityconfigmapreference.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/client-go/config/applyconfigurations/config/v1/externalsourcepredicate.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/client-go/config/applyconfigurations/config/v1/externalsourcetls.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/client-go/config/applyconfigurations/config/v1/networkobservabilityspec.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/client-go/config/applyconfigurations/config/v1/networkspec.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/client-go/config/applyconfigurations/config/v1/oidcprovider.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/client-go/config/applyconfigurations/config/v1/sourcedclaimmapping.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/client-go/config/applyconfigurations/config/v1/sourceurl.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/client-go/config/applyconfigurations/config/v1/tlsprofilespec.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/client-go/config/applyconfigurations/config/v1/tlssecurityprofile.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/client-go/config/applyconfigurations/config/v1/vaultapproleauthentication.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/client-go/config/applyconfigurations/config/v1/vaultkmspluginconfig.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/client-go/config/applyconfigurations/config/v1/vaulttlsconfig.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/client-go/config/applyconfigurations/config/v1alpha1/alertmanagercustomconfig.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/client-go/config/applyconfigurations/config/v1alpha1/nodeexporterconfig.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/client-go/config/applyconfigurations/config/v1alpha1/thanosquerierconfig.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/client-go/config/applyconfigurations/config/v1alpha1/thanosquerierrequestloggingconfig.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/client-go/config/applyconfigurations/internal/internal.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/client-go/config/applyconfigurations/utils.gois excluded by!vendor/**,!**/vendor/**vendor/modules.txtis excluded by!vendor/**,!**/vendor/**
📒 Files selected for processing (6)
Makefilecloud-provider-awscontainernetworking-pluginsgo.modkubeletovn-kubernetes
| github.com/go-openapi/jsonpointer v0.23.1 // indirect | ||
| github.com/go-openapi/jsonreference v0.21.6 // indirect |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Search for direct usage of go-openapi packages in the codebase
echo "=== Checking for direct go-openapi usage ==="
rg -n --type=go "github.com/go-openapi/(jsonpointer|jsonreference|swag)" --no-heading
# Check the go-openapi/swag changelog for v0.26.x breaking changes
echo -e "\n=== Checking go-openapi/swag release notes ==="
gh api repos/go-openapi/swag/releases --jq '.[] | select(.tag_name | startswith("v0.26")) | {tag_name, published_at, body}'Repository: openshift/windows-machine-config-operator
Length of output: 43504
Check swag/jsonname behavior change compatibility for the indirect go-openapi bumps.
The jsonpointer/jsonreference updates are indirect, and current usage shows up only via vendored k8s.io/kube-openapi. The swag/jsonname jump is the main risk: swag v0.26.0 introduces a new json name provider, and v0.26.1 adds a loading sandbox with security implications. Run the usual verification (e.g., make verify) to catch any OpenAPI/schema naming regressions.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@go.mod` around lines 67 - 68, Verify compatibility of the indirect go-openapi
bumps by running the project's OpenAPI/schema checks: ensure the upgrade of
github.com/go-openapi/jsonpointer and github.com/go-openapi/jsonreference
doesn't change generated JSON names by exercising the swagger toolchain that
pulls in swag/jsonname (check swag v0.26.x behavior); run the standard
verification target (e.g., make verify) and inspect any diffs in generated
OpenAPI specs or schema name mappings (pay special attention to swag/jsonname
behavior and k8s.io/kube-openapi vendored usage), and if regressions appear, pin
or update swag/jsonname usage or adjust generation code to restore previous json
name behavior.
Source: Coding guidelines
|
/retest-required |
1 similar comment
|
/retest-required |
|
@jrvaldes: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest-required |
Summary by CodeRabbit