Skip to content

Update Boilerplate to Fix CI Issues#559

Open
devppratik wants to merge 1 commit into
openshift:masterfrom
devppratik:update-boilerplate-jun-2026
Open

Update Boilerplate to Fix CI Issues#559
devppratik wants to merge 1 commit into
openshift:masterfrom
devppratik:update-boilerplate-jun-2026

Conversation

@devppratik

@devppratik devppratik commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Updates boilerplate to the latest version
  • Updates UBI minimal image to 9.8-1780378819
  • Updates boilerplate image to v8.3.6
  • Syncs PKO CRDs

Changes

  • Updated boilerplate commit reference
  • Refreshed generated files from latest boilerplate templates
  • Synced CRDs: clusterurlmonitors, routemonitors

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores

    • Updated developer setup documentation with additional installation options.
    • Updated team member assignments.
  • Refactor

    • Reformatted Kubernetes Custom Resource Definition schemas for improved clarity.
    • Removed unnecessary default values from boolean fields in resource definitions, allowing for more flexible schema validation.
    • Upgraded controller generation tool version.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 4, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: c13c0af1-ee82-4461-9d43-f35dd25eefd9

📥 Commits

Reviewing files that changed from the base of the PR and between 2af1624 and 9cf48cf.

⛔ Files ignored due to path filters (8)
  • boilerplate/_data/last-boilerplate-commit is excluded by !boilerplate/**
  • boilerplate/openshift/golang-osd-operator/OWNERS_ALIASES is excluded by !boilerplate/**
  • boilerplate/openshift/golang-osd-operator/docs/pre-commit.md is excluded by !boilerplate/**
  • boilerplate/openshift/golang-osd-operator/olm_pko_migration.py is excluded by !boilerplate/**
  • boilerplate/openshift/golang-osd-operator/pre-commit-config.yaml is excluded by !boilerplate/**
  • boilerplate/openshift/golang-osd-operator/standard.mk is excluded by !boilerplate/**
  • build/Dockerfile is excluded by !build/**
  • build/Dockerfile.olm-registry is excluded by !build/**
📒 Files selected for processing (4)
  • .pre-commit-config.yaml
  • OWNERS_ALIASES
  • deploy_pko/CustomResourceDefinition-clusterurlmonitors.monitoring.openshift.io.yaml
  • deploy_pko/CustomResourceDefinition-routemonitors.monitoring.openshift.io.yaml

Walkthrough

This PR updates developer setup documentation to include uv-based installation and a pinned pre-commit version; modifies team ownership aliases for the functional team; and regenerates CRD schemas with updated formatting and controller-gen version bumps while removing default values from boolean schema fields.

Changes

Configuration and Schema Updates

Layer / File(s) Summary
Developer Setup Documentation
.pre-commit-config.yaml
INSTALL section expanded with uv quick-start instructions and explicit pre-commit==4.6.0 pinned install command; comments added explaining how to exclude fix commits from git blame via an ignore-revs-file.
Team Ownership Configuration
OWNERS_ALIASES
Team alias srep-functional-team-aurora updated to include BATMAN-JD and geowa4 while removing luis-falcon.
CRD Schema Updates
deploy_pko/CustomResourceDefinition-clusterurlmonitors.monitoring.openshift.io.yaml, deploy_pko/CustomResourceDefinition-routemonitors.monitoring.openshift.io.yaml
ClusterUrlMonitors CRD schema descriptions reformatted to YAML block-scalar style; RouteMonitors CRD controller-gen version bumped to v0.16.4 with schema descriptions similarly reformatted and default values removed from insecureSkipTLSVerify and skipPrometheusRule boolean fields.

🎯 1 (Trivial) | ⏱️ ~4 minutes


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (2 errors, 2 warnings)

Check name Status Explanation Resolution
Stable And Deterministic Test Names ❌ Error Found 3 Ginkgo test titles containing hardcoded numeric timeout values (20 seconds) that are overly-specific and likely to change during development iterations. Remove hardcoded "20 seconds" from test titles in int/int_test.go (lines 71, 241, 312) and replace with descriptive static names like "creates a ServiceMonitor within a reasonable timeframe".
Ote Binary Stdout Contract ❌ Error fips.go contains fmt.Println() in init() function, which writes to stdout at process startup. This violates OTE Binary Stdout Contract by corrupting JSON output required by openshift-tests. Remove fmt.Println() from fips.go init() function or redirect output to stderr using fmt.Fprintf(os.Stderr, ...) instead.
Microshift Test Compatibility ⚠️ Warning New Ginkgo e2e tests in test/e2e/route_monitor_operator_tests.go use HostedControlPlane API (hypershift.openshift.io) which is not available on MicroShift. Tests lack required protection mechanisms. Add [apigroup:hypershift.openshift.io] tag to tests referencing HostedControlPlane, or use g.Skip() with MicroShift detection, or add [Skipped:MicroShift] label if intentionally unsupported.
Ipv6 And Disconnected Network Test Compatibility ⚠️ Warning New tests in test/e2e/route_monitor_operator_tests.go pull external images (quay.io) and make HTTP calls to OIDC/RHOBS API endpoints, failing in disconnected environments. Add [Skipped:Disconnected] tag to tests or use internal services. Use mock OIDC/RHOBS endpoints. Run tests with IPv6 CI job to verify IPv6 compatibility.
✅ Passed checks (11 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main objective of updating boilerplate and fixing CI issues, which aligns with the PR summary describing boilerplate updates, image refreshes, and CRD syncs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Test Structure And Quality ✅ Passed No Ginkgo test files are modified in this PR. Changes are limited to boilerplate, YAML configuration, CRDs, and Dockerfiles. The test structure check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed New Ginkgo e2e tests use standard OpenShift APIs with single pods/deployments compatible on one node; no multi-node assumptions or affinity/topology constraints found.
Topology-Aware Scheduling Compatibility ✅ Passed Deployment uses topology-compatible scheduling: preferred affinity, single replica, specific tolerations only, no control-plane selectors or required anti-affinity constraints.
No-Weak-Crypto ✅ Passed Comprehensive scan found no weak cryptographic algorithms (MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB), no custom crypto implementations, and no non-constant-time secret comparisons in the PR code.
Container-Privileges ✅ Passed No container privilege escalation found. Deployments use allowPrivilegeEscalation: false and runAsNonRoot: true. No privileged, hostPID, hostNetwork, SYS_ADMIN, or root execution detected.
No-Sensitive-Data-In-Logs ✅ Passed PR modifies configuration and CRD schema files only (.pre-commit-config.yaml, OWNERS_ALIASES, YAML manifests), which contain no logging statements. Application logging code is outside PR scope.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
openshift-ci Bot requested review from Mhodesty and anispate June 4, 2026 14:46
@openshift-ci

openshift-ci Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

@devppratik: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.60%. Comparing base (2af1624) to head (9cf48cf).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #559   +/-   ##
=======================================
  Coverage   57.60%   57.60%           
=======================================
  Files          31       31           
  Lines        2913     2913           
=======================================
  Hits         1678     1678           
  Misses       1110     1110           
  Partials      125      125           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@krishvoor

Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2026
@openshift-ci

openshift-ci Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: devppratik, krishvoor
Once this PR has been reviewed and has the lgtm label, please assign dustman9000 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dustman9000

Copy link
Copy Markdown
Member

/rebase
/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants