Skip to content

Update Boilerplate to Fix CI Issues#441

Open
devppratik wants to merge 1 commit into
openshift:masterfrom
devppratik:update-boilerplate-jun-2026
Open

Update Boilerplate to Fix CI Issues#441
devppratik wants to merge 1 commit into
openshift:masterfrom
devppratik:update-boilerplate-jun-2026

Conversation

@devppratik

@devppratik devppratik commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Updates boilerplate to the latest version
  • Updates UBI minimal image to 9.8-1780378819
  • Updates boilerplate image to v8.3.6
  • Syncs PKO CRDs

Changes

  • Updated boilerplate commit reference
  • Refreshed generated files from latest boilerplate templates
  • Synced CRD: pagerdutyintegrations

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated configuration documentation with improved setup guidance and pinned dependency versions for development tools
    • Reformatted Kubernetes resource definition schema to enhance consistency and maintainability

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@openshift-ci openshift-ci Bot requested review from aliceh and nephomaniac June 4, 2026 14:46
@openshift-ci

openshift-ci Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: devppratik
Once this PR has been reviewed and has the lgtm label, please assign bergmannf for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jun 4, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: b42788fa-0247-4bb9-b1ee-642fc5f89ae6

📥 Commits

Reviewing files that changed from the base of the PR and between 6fb9725 and 748d691.

⛔ Files ignored due to path filters (7)
  • boilerplate/_data/last-boilerplate-commit is excluded by !boilerplate/**
  • boilerplate/openshift/golang-osd-operator/docs/pre-commit.md is excluded by !boilerplate/**
  • boilerplate/openshift/golang-osd-operator/olm_pko_migration.py is excluded by !boilerplate/**
  • boilerplate/openshift/golang-osd-operator/pre-commit-config.yaml is excluded by !boilerplate/**
  • boilerplate/openshift/golang-osd-operator/standard.mk is excluded by !boilerplate/**
  • build/Dockerfile is excluded by !build/**
  • build/Dockerfile.olm-registry is excluded by !build/**
📒 Files selected for processing (2)
  • .pre-commit-config.yaml
  • deploy_pko/CustomResourceDefinition-pagerdutyintegrations.pagerduty.openshift.io.yaml

Walkthrough

This PR updates developer setup documentation in .pre-commit-config.yaml by adding uv-based quick start guidance and pinning pre-commit to version 4.6.0, while also regenerating the PagerDutyIntegration CustomResourceDefinition's OpenAPI v3 schema with reformatted YAML without changing the underlying structure.

Changes

Maintenance and Configuration Updates

Layer / File(s) Summary
Developer setup and pre-commit documentation
.pre-commit-config.yaml
Pre-commit configuration comments updated with uv-based quick start workflow and pip pre-commit version pinned to 4.6.0; extended git blame exclusion documentation with link reference.
CRD schema formatting regeneration
deploy_pko/CustomResourceDefinition-pagerdutyintegrations.pagerduty.openshift.io.yaml
PagerDutyIntegration CustomResourceDefinition YAML schema regenerated with updated formatting, indentation, and line-wrapping in descriptions and property definitions; no changes to field structure, nesting, or CRD configuration.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error, 1 inconclusive)

Check name Status Explanation Resolution
Ote Binary Stdout Contract ❌ Error The fips.go file contains fmt.Println() in a process-level init() function, which writes non-JSON text to stdout and violates OTE binary's JSON stdout contract. Replace fmt.Println() with stderr output (e.g., fmt.Fprintln(os.Stderr, ...)) or use the structured logger (setupLog.Info).
Title check ❓ Inconclusive The title 'Update Boilerplate to Fix CI Issues' is partially related to the changeset but lacks specificity about the main changes. Consider a more descriptive title that captures the primary change, such as 'Update boilerplate to v8.3.6 and sync CRDs' or 'Update boilerplate version and UBI minimal image'.
✅ Passed checks (13 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Repository does not use Ginkgo BDD test framework. All tests use standard Go testing with testify assertions. Check is not applicable.
Test Structure And Quality ✅ Passed PR only modifies configuration and CRD files. No Ginkgo tests changed; codebase uses testify and GoMock instead, so check is not applicable.
Microshift Test Compatibility ✅ Passed No new Ginkgo e2e tests were added in this PR. Changes are limited to boilerplate, configuration, and YAML manifests. The check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR does not add any Ginkgo e2e tests. It only updates boilerplate configuration, CRD formatting, and documentation. The SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed No scheduling constraints were introduced in deployment manifests, operator code, or controllers. PR contains only pre-commit config documentation updates and CRD formatting changes.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No Ginkgo e2e tests are added in this PR. Changes are limited to boilerplate configuration, YAML manifests, and standard Go unit tests using the testing package, not Ginkgo.
No-Weak-Crypto ✅ Passed No weak crypto (MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB), custom crypto implementations, or unsafe secret comparisons found in the codebase or PR changes.
Container-Privileges ✅ Passed No privileged container settings (privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation, or root user) detected in any Kubernetes manifests modified by this PR.
No-Sensitive-Data-In-Logs ✅ Passed Modified files contain no logging statements, hardcoded credentials, or sensitive data; only configuration and schema definitions.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.07%. Comparing base (12b4c06) to head (748d691).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #441   +/-   ##
=======================================
  Coverage   61.07%   61.07%           
=======================================
  Files          22       22           
  Lines        1824     1824           
=======================================
  Hits         1114     1114           
  Misses        567      567           
  Partials      143      143           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@openshift-ci

openshift-ci Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

@devppratik: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/validate 748d691 link true /test validate

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 5, 2026
@openshift-ci

openshift-ci Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants