Skip to content

ROSA-745: per-repo dependency automation config #917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
MitaliBhalla wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

ROSA-745: per-repo dependency automation config #917

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,24 @@
version: 2
updates:
- package-ecosystem: 'gomod'
- package-ecosystem: gomod
directory: '/'
labels:
- "area/dependency"
- "ok-to-test"
allow:
- dependency-name: "github.com/openshift/osd-network-verifier"
- dependency-name: "github.com/openshift/backplane-cli"
schedule:
interval: 'daily'
interval: 'weekly'
open-pull-requests-limit: 10
groups:
aws-sdk:
patterns:
- "github.com/aws/aws-sdk-go-v2*"
kubernetes:
patterns:
- "k8s.io/*"
- "sigs.k8s.io/*"
openshift:
patterns:
- "github.com/openshift/*"
Comment on lines 8 to +24

@coderabbitai coderabbitai Bot Jun 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical | ⚡ Quick win

The allow list conflicts with the groups configuration—aws-sdk and kubernetes groups are unreachable.

Dependabot's allow field restricts updates to only the listed dependencies. Currently, only two OpenShift packages are allowed:

  • github.com/openshift/osd-network-verifier
  • github.com/openshift/backplane-cli

This means:

  • The aws-sdk group (line 15-17) will never trigger updates because no AWS SDK dependencies are in the allow list.
  • The kubernetes group (line 18-21) will never trigger updates because no k8s.io or sigs.k8s.io dependencies are in the allow list.
  • Only the openshift group could match the two allowed dependencies.

Action required: Either:

  1. Remove the allow block entirely to enable updates for all dependencies (recommended if you want AWS SDK and Kubernetes updates), OR
  2. Remove the unused aws-sdk and kubernetes groups if they're not needed, OR
  3. Expand the allow list to include specific AWS and Kubernetes dependencies that should be updated.
♻️ Option 1: Remove allow block to enable all dependency updates 
     labels:
       - "area/dependency"
       - "ok-to-test"
-    allow:
-      - dependency-name: "github.com/openshift/osd-network-verifier"
-      - dependency-name: "github.com/openshift/backplane-cli"
     schedule:
       interval: 'weekly'
♻️ Option 2: Remove unused groups 
     open-pull-requests-limit: 10
     groups:
-      aws-sdk:
-        patterns:
-          - "github.com/aws/aws-sdk-go-v2*"
-      kubernetes:
-        patterns:
-          - "k8s.io/*"
-          - "sigs.k8s.io/*"
       openshift:
         patterns:
           - "github.com/openshift/*"
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
allow:
- dependency-name: "github.com/openshift/osd-network-verifier"
- dependency-name: "github.com/openshift/backplane-cli"
schedule:
interval: 'daily'
interval: 'weekly'
open-pull-requests-limit: 10
groups:
aws-sdk:
patterns:
- "github.com/aws/aws-sdk-go-v2*"
kubernetes:
patterns:
- "k8s.io/*"
- "sigs.k8s.io/*"
openshift:
patterns:
- "github.com/openshift/*"
schedule:
interval: 'weekly'
open-pull-requests-limit: 10
groups:
aws-sdk:
patterns:
- "github.com/aws/aws-sdk-go-v2*"
kubernetes:
patterns:
- "k8s.io/*"
- "sigs.k8s.io/*"
openshift:
patterns:
- "github.com/openshift/*"
Suggested change
allow:
- dependency-name: "github.com/openshift/osd-network-verifier"
- dependency-name: "github.com/openshift/backplane-cli"
schedule:
interval: 'daily'
interval: 'weekly'
open-pull-requests-limit: 10
groups:
aws-sdk:
patterns:
- "github.com/aws/aws-sdk-go-v2*"
kubernetes:
patterns:
- "k8s.io/*"
- "sigs.k8s.io/*"
openshift:
patterns:
- "github.com/openshift/*"
allow:
- dependency-name: "github.com/openshift/osd-network-verifier"
- dependency-name: "github.com/openshift/backplane-cli"
schedule:
interval: 'weekly'
open-pull-requests-limit: 10
groups:
openshift:
patterns:
- "github.com/openshift/*"
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/dependabot.yml around lines 8 - 24, The dependabot config's allow
list currently limits updates to only the two OpenShift packages, making the
"aws-sdk" and "kubernetes" groups unreachable; fix by either removing the
top-level allow block (so groups aws-sdk, kubernetes, openshift are evaluated),
or if you want to keep allow, remove the unused "aws-sdk" and "kubernetes" group
entries, or expand the allow list to include the specific AWS and Kubernetes
dependencies you want Dependabot to update (update the "allow" entries or adjust
"groups" patterns accordingly).