ROSAENG-14080: Support MC/SC cluster ID usage with hcp-mustgathers

[MateSaary]

Previously, MC and SC kubeconfigs were resolved upfront regardless of gather targets, and only HCP cluster IDs were accepted as input.

Changes:

• Cluster resolution is now lazy and scoped to each gather target
• MC and SC cluster IDs are accepted directly for --gather mc/sc
• --gather hcp fails immediately with a clear error for non-HCP IDs
• The existing OCM connection is reused throughout instead of opening
  new connections per goroutine

[openshift-ci-robot]

@MateSaary: This pull request references ROSAENG-14080 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Previously, MC and SC kubeconfigs were resolved upfront regardless of
gather targets, and only HCP cluster IDs were accepted as input.

Changes:

• Cluster resolution is now lazy and scoped to each gather target
• MC and SC cluster IDs are accepted directly for --gather mc/sc
• --gather hcp fails immediately with a clear error for non-HCP IDs
• The existing OCM connection is reused throughout instead of opening
  new connections per goroutine

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Warning

Review limit reached

@MateSaary, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 46 minutes and 50 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 78077c72-2a0a-4b3d-bc55-9180ed791314

📥 Commits

Reviewing files that changed from the base of the PR and between a96132f and 98cf795.

📒 Files selected for processing (1)

• cmd/hcp/mustgather/mustGather.go

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MateSaary

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [MateSaary]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@MateSaary: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.