Skip to content

e2e: move AdminKubeClient() from init to BeforeEach in router config_manager test #31335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
redhat-chai-bot wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

e2e: move AdminKubeClient() from init to BeforeEach in router config_manager test #31335

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/extended/router/config_manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,9 @@ var _ = g.Describe("[sig-network][Feature:Router][apigroup:route.openshift.io]",
// in order to allow binding 80/443 without being root. Without the privilege,
// the capability does not take effect and haproxy fails to start.
oc = exutil.NewCLIWithPodSecurityLevel("router-config-manager", api.LevelPrivileged)

@stbenjam stbenjam Jun 24, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The oc here is also suspect to me, I think this is also a previously known problem to have it outside in places that get run when ginkgo builds the tree

@stbenjam stbenjam Jun 24, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See Chai's comment below, it really should've replied in the thread

kubeClient = oc.AdminKubeClient()

g.BeforeEach(func() {
kubeClient = oc.AdminKubeClient()
ns = oc.Namespace()

routerImage, err := exutil.FindRouterImage(oc)
Expand Down