NO-JIRA: add minio image to allowed list

[gangwgr]

Summary by CodeRabbit

• Tests
  • Fixed test framework to correctly recognize known Docker images, eliminating false positives in test failure reports.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gangwgr
Once this PR has been reviewed and has the lgtm label, please assign jogeo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

Walkthrough

A single entry (quay.io/minio/minio:RELEASE.2025-09-07T16-13-09Z) is appended to the static allowedPrefixes set in the known image checker monitor test, exempting that image tag from being reported as an unknown or unmirrored image.

Changes

Known Image Checker Allowlist Update

Layer / File(s)	Summary
Add minio image to allowedPrefixes pkg/monitortests/testframework/knownimagechecker/monitortest.go	Adds quay.io/minio/minio:RELEASE.2025-09-07T16-13-09Z to the allowedPrefixes set so pulls of this image are not flagged as unknown.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The modified file contains no Ginkgo test definitions (It, Describe, Context, When) and the single line added is an image prefix string used in test validation logic, not a test name.
Test Structure And Quality	✅ Passed	File modified is a monitoring framework component, not Ginkgo test code. The change adds a minio image to an allowed list—a configuration change, not test logic requiring review against Ginkgo test...
Microshift Test Compatibility	✅ Passed	No new Ginkgo e2e tests are added in this PR. The file is a monitor test framework component implementing MonitorTest interface, with no test definitions (It, Describe, Context, When). Check does n...
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This PR does not add any new Ginkgo e2e tests; it only adds an image to an allowed list in a monitor test utility. The SNO compatibility check applies only to new tests.
Topology-Aware Scheduling Compatibility	✅ Passed	PR adds minio image to allowlist in test monitoring code; not a deployment/operator/controller change with scheduling constraints. Check does not apply to test infrastructure modifications.
Ote Binary Stdout Contract	✅ Passed	The PR change only adds an image prefix to a data structure within a method (EvaluateTestsFromConstructedIntervals), which is not process-level code. It does not create, modify, or configure stdout...
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	This PR does not add new Ginkgo e2e tests; it only adds an image to an allowlist in a monitoring framework validator. The check is not applicable.
No-Weak-Crypto	✅ Passed	The PR only adds a Docker image to an allowed list string. The modified file contains no crypto imports, weak crypto algorithms, custom crypto implementations, or secret comparisons.
Container-Privileges	✅ Passed	PR adds minio image to an allowed list in Go test framework code. No container/Kubernetes manifests with privileged settings are introduced.
No-Sensitive-Data-In-Logs	✅ Passed	The change adds a standard Docker image reference (quay.io/minio/minio:RELEASE.2025-09-07T16-13-09Z) to an allowlist, containing no passwords, tokens, API keys, PII, or sensitive data.
Title check	✅ Passed	The title accurately summarizes the change by adding the MinIO image to the allowed list.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-merge-bot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[gangwgr]

/test e2e-gcp-ovn-upgrade

[gangwgr]

/retest-required

[gangwgr]

/retest

[gangwgr]

/retest

[gangwgr]

/retest

[gangwgr]

/retest

[gangwgr]

/retest

[gangwgr]

/retest

[gangwgr]

/test e2e-aws-ovn-fips

[gangwgr]

/retest-required

[openshift-ci-robot]

@gangwgr: This pull request explicitly references no jira issue.

Details

In response to this:

Summary by CodeRabbit

• Tests
• Fixed test framework to correctly recognize known Docker images, eliminating false positives in test failure reports.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[gangwgr]

/test e2e-vsphere-ovn

[gangwgr]

/test e2e-vsphere-ovn

[xueqzhan]

Is this really needed? Try to follow test/extended/util/image/README.md and use image.LocationFor("quay.io/minio/minio:RELEASE.2025-09-07T16-13-09Z") when you need the image. Your image should already be in the fromRepository once you do that.

Since your image is referenced in yaml, you might need to override the image in Go code after reading the YAML — read the YAML into a Go object, then set the image field programmatically:

  deployment := resourceread.ReadDeploymentV1OrDie(yamlBytes)
  deployment.Spec.Template.Spec.Containers[0].Image = image.LocationFor("quay.io/minio/minio:RELEASE.2025-09-07T16-13-09Z")

There should be examples in the code for that.

[gangwgr]

Is this really needed? Try to follow test/extended/util/image/README.md and use image.LocationFor("quay.io/minio/minio:RELEASE.2025-09-07T16-13-09Z") when you need the image. Your image should already be in the fromRepository once you do that.

Since your image is referenced in yaml, you might need to override the image in Go code after reading the YAML — read the YAML into a Go object, then set the image field programmatically:

  deployment := resourceread.ReadDeploymentV1OrDie(yamlBytes)
  deployment.Spec.Template.Spec.Containers[0].Image = image.LocationFor("quay.io/minio/minio:RELEASE.2025-09-07T16-13-09Z")

There should be examples in the code for that.

@xueqzhan I tried every same steps as in origin and mirroring also, but still job is failing https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_cluster-image-registry-operator/1343/pull-ci-openshift-cluster-image-registry-operator-main-e2e-aws-operator-serial-ote/2070007906870235136

[openshift-ci]

@gangwgr: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.