Skip to content

OCPBUGS-84512: Remove exception terminationMessagePolicy=TerminationMessageFallbackToLogsOnError #31327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
theobarberbany wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OCPBUGS-84512: Remove exception terminationMessagePolicy=TerminationMessageFallbackToLogsOnError #31327

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions pkg/monitortests/clusterversionoperator/terminationmessagepolicy/monitortest.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,14 +111,12 @@ func (w *terminationMessagePolicyChecker) CollectData(ctx context.Context, stora
if container.TerminationMessagePolicy != corev1.TerminationMessageFallbackToLogsOnError {
failuresByNamespace[pod.Namespace] = append(failuresByNamespace[pod.Namespace],
fmt.Sprintf("pods/%s containers[%v]", pod.Name, container.Name))

}
}
for _, container := range pod.Spec.EphemeralContainers {
if container.TerminationMessagePolicy != corev1.TerminationMessageFallbackToLogsOnError {
failuresByNamespace[pod.Namespace] = append(failuresByNamespace[pod.Namespace],
fmt.Sprintf("pods/%s ephemeralContainers[%v]", pod.Name, container.Name))

}
}
}
Expand All @@ -138,7 +136,6 @@ func (w *terminationMessagePolicyChecker) CollectData(ctx context.Context, stora
// per TRT-2084 these were erroneously allowed to flake, so grandfather them in for now.
// they should be fixed and removed from here:
"openshift-backplane": sets.NewString("pods/osd-delete-backplane-serviceaccounts"), // filed OCPBUGS-84527 to fix
"openshift-cloud-controller-manager": sets.NewString("pods/aws-cloud-controller-manager"), // filed OCPBUGS-84512 to fix
"openshift-cluster-machine-approver": sets.NewString("pods/machine-approver-capi"), // filed OCPBUGS-84521 to fix
"openshift-cluster-version": sets.NewString("pods/version--"), // filed OCPBUGS-84513 to fix
"openshift-cnv": sets.NewString( // filed OCPBUGS-84522 to fix
Expand Down