Skip to content

CORENET-7135: Add OVS layer tools into openshift-mcp-server#336

Draft
taanyas wants to merge 2 commits into
openshift:mainfrom
taanyas:corenet-7135
Draft

CORENET-7135: Add OVS layer tools into openshift-mcp-server#336
taanyas wants to merge 2 commits into
openshift:mainfrom
taanyas:corenet-7135

Conversation

@taanyas

@taanyas taanyas commented Jun 10, 2026

Copy link
Copy Markdown

Stacked on top of #315 (ovn-kubernetes toolset skeleton). The first commit is for toolset skeleton, the second commit adds the OVS layer.

Adds 7 OVS tools to the ovn-kubernetes toolset:

  • ovs_vsctl_show
  • ovs_list_br
  • ovs_list_ports
  • ovs_list_ifaces
  • ovs_ofctl_dump_flows
  • ovs_appctl_dump_conntrack
  • ovs_appctl_ofproto_trace

Verified locally:

  • make build clean, make test passes
  • MCP Inspector: all 7 tools registered with correct schemas
  • End-to-end against an OVN-Kubernetes KIND cluster: ovs_list_br returns the expected bridges.

TODO before ready-for-review:

  • Restructure based on final design — likely splitting tools into subgroups (e.g. vsctl tools vs ofctl/appctl tools) rather than one flat tools.go. Open to feedback on the right grouping.
  • Evals
  • Align param name filterpattern with upstream
  • Rebase once CORENET-7134: Add ovn-kubernetes toolset skeleton #315 merges (will dedupe shared vendor automatically)

mattedallo and others added 2 commits June 9, 2026 02:14
Register an empty ovn-kubernetes toolset so sibling stories (CORENET-7135/7136)
can land OVN/OVS tool handlers on top of this framework.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Matteo Dallaglio <mdallagl@redhat.com>
Signed-off-by: Tanya Singh <tasingh@redhat.com>
@openshift-ci

openshift-ci Bot commented Jun 10, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 10, 2026
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 10, 2026
@openshift-ci-robot

openshift-ci-robot commented Jun 10, 2026

Copy link
Copy Markdown

@taanyas: This pull request references CORENET-7135 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Stacked on top of #315 (ovn-kubernetes toolset skeleton). The first commit is for toolset skeleton, the second commit adds the OVS layer.

Adds 7 OVS tools to the ovn-kubernetes toolset:

  • ovs_vsctl_show
  • ovs_list_br
  • ovs_list_ports
  • ovs_list_ifaces
  • ovs_ofctl_dump_flows
  • ovs_appctl_dump_conntrack
  • ovs_appctl_ofproto_trace

Verified locally:

  • make build clean, make test passes
  • MCP Inspector: all 7 tools registered with correct schemas
  • End-to-end against an OVN-Kubernetes KIND cluster: ovs_list_br returns the expected bridges.

TODO before ready-for-review:

  • Restructure based on final design — likely splitting tools into subgroups (e.g. vsctl tools vs ofctl/appctl tools) rather than one flat tools.go. Open to feedback on the right grouping.
  • Evals
  • Align param name filterpattern with upstream
  • Rebase once CORENET-7134: Add ovn-kubernetes toolset skeleton #315 merges (will dedupe shared vendor automatically)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 02198374-b867-401c-bdbd-046536a72bd9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 10, 2026
@openshift-ci

openshift-ci Bot commented Jun 10, 2026

Copy link
Copy Markdown

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci

openshift-ci Bot commented Jun 10, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: taanyas
Once this PR has been reviewed and has the lgtm label, please assign cali0707 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants