Skip to content

ROSA-745: boilerplate-update and enable MintMaker gomod#555

Open
MitaliBhalla wants to merge 1 commit into
openshift:masterfrom
MitaliBhalla:rosa-745-mintmaker-gomod
Open

ROSA-745: boilerplate-update and enable MintMaker gomod#555
MitaliBhalla wants to merge 1 commit into
openshift:masterfrom
MitaliBhalla:rosa-745-mintmaker-gomod

Conversation

@MitaliBhalla

@MitaliBhalla MitaliBhalla commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Summary

  • make boilerplate-update (includes boilerplate #748 dependabot template)
  • .github/renovate.jsonenabledManagers: [tekton, gomod] for MintMaker gomod PRs

Test plan

  • CI green

Jira: ROSA-745

Summary by CodeRabbit

  • Chores
    • Updated dependency management automation configuration to enable additional manager support for improved dependency handling.

@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown

Caution

Review failed

An error occurred during the review process. Please try again later.

Walkthrough

The pull request updates .github/renovate.json to explicitly configure Renovate to enable the tekton and gomod managers via a new enabledManagers array. The extends array termination is adjusted with a trailing comma to support the additional configuration.

Changes

Renovate Configuration

Layer / File(s) Summary
Enable tekton and gomod managers
.github/renovate.json
A top-level enabledManagers array is added to explicitly enable tekton and gomod dependency managers, with the extends array adjusted to include a trailing comma.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 12, 2026
@openshift-ci-robot

openshift-ci-robot commented Jun 12, 2026

Copy link
Copy Markdown

@MitaliBhalla: This pull request references ROSA-745 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the initiative to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

  • make boilerplate-update (includes boilerplate #748 dependabot template)
  • .github/renovate.jsonenabledManagers: [tekton, gomod] for MintMaker gomod PRs

Test plan

  • CI green

Jira: ROSA-745

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from diakovnec and tnierman June 12, 2026 08:17
@openshift-ci

openshift-ci Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MitaliBhalla

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2026
@MitaliBhalla

Copy link
Copy Markdown
Contributor Author

/retest-required

1 similar comment
@MitaliBhalla

Copy link
Copy Markdown
Contributor Author

/retest-required

Run make boilerplate-update and set renovate enabledManagers to tekton/gomod.

Co-authored-by: Cursor <cursoragent@cursor.com>
@MitaliBhalla MitaliBhalla force-pushed the rosa-745-mintmaker-gomod branch from 9699e0d to f27ecfa Compare June 12, 2026 09:54
@openshift-ci

openshift-ci Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

@MitaliBhalla: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@MitaliBhalla

Copy link
Copy Markdown
Contributor Author

/retest-required

1 similar comment
@MitaliBhalla

Copy link
Copy Markdown
Contributor Author

/retest-required

@xiaoyu74

Copy link
Copy Markdown
Contributor

can see you've closed the previous #554 and created this new #555 , could you clarify a bit why #554 was closed and replaced by #555?

Comment thread .github/renovate.json
"extends": [
"github>openshift/boilerplate//.github/renovate.json"
],
"enabledManagers": [

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this MCVW really needs this explicitly for MintMaker gomod to run, instead of relying only on the inherited boilerplate renovate config?

as you mentioned earlier pagerduty-operator was used as a reference case, but I want to understand whether this is a `Renovate/MintMaker merge behavior or a rollout workaround?

@xiaoyu74

Copy link
Copy Markdown
Contributor

btw, can see we have one konflux CI job failed, once we understand the reduced scope in this new #555 and CI it's green, it should be much easier to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants