ROSA-745: boilerplate-update and enable MintMaker gomod#555
ROSA-745: boilerplate-update and enable MintMaker gomod#555MitaliBhalla wants to merge 1 commit into
Conversation
|
Caution Review failedAn error occurred during the review process. Please try again later. WalkthroughThe pull request updates ChangesRenovate Configuration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@MitaliBhalla: This pull request references ROSA-745 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the initiative to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MitaliBhalla The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required |
1 similar comment
|
/retest-required |
Run make boilerplate-update and set renovate enabledManagers to tekton/gomod. Co-authored-by: Cursor <cursoragent@cursor.com>
9699e0d to
f27ecfa
Compare
|
@MitaliBhalla: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest-required |
1 similar comment
|
/retest-required |
|
can see you've closed the previous #554 and created this new #555 , could you clarify a bit why #554 was closed and replaced by #555?
|
| "extends": [ | ||
| "github>openshift/boilerplate//.github/renovate.json" | ||
| ], | ||
| "enabledManagers": [ |
There was a problem hiding this comment.
Does this MCVW really needs this explicitly for MintMaker gomod to run, instead of relying only on the inherited boilerplate renovate config?
as you mentioned earlier pagerduty-operator was used as a reference case, but I want to understand whether this is a `Renovate/MintMaker merge behavior or a rollout workaround?
|
btw, can see we have one konflux CI job failed, once we understand the reduced scope in this new #555 and CI it's green, it should be much easier to review. |
Summary
make boilerplate-update(includes boilerplate #748 dependabot template).github/renovate.json—enabledManagers: [tekton, gomod]for MintMaker gomod PRsTest plan
Jira: ROSA-745
Summary by CodeRabbit