Skip to content

crypto: clarify TLS cipher mapping and rename internal maps #2325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sanchezl wants to merge 6 commits into from
Closed

crypto: clarify TLS cipher mapping and rename internal maps #2325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b5ddf21
Bump openshift/api and openshift/client-go
jubittajohn Jun 22, 2026
baafe22
Handle TLS profile ciphers unsupported by Go's crypto/tls
jubittajohn Jun 22, 2026
2ef05f5
crypto: clarify cipher mapping documentation and co-locate skip list
sanchezl Jun 22, 2026
5db4427
crypto: rename unexported maps for clarity
sanchezl Jun 22, 2026
54252a6
crypto: rename TLS version maps for clarity
sanchezl Jun 22, 2026
b4c85f9
crypto: log silently dropped ciphers at V(4)
sanchezl Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
45 changes: 27 additions & 18 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,22 +18,22 @@ require (
github.com/onsi/gomega v1.38.2
github.com/opencontainers/go-digest v1.0.0
github.com/opencontainers/selinux v1.13.0
github.com/openshift/api v0.0.0-20260521125114-09730f85d883
github.com/openshift/api v0.0.0-20260619095050-5346161d1bf2
github.com/openshift/build-machinery-go v0.0.0-20250530140348-dc5b2804eeee
github.com/openshift/client-go v0.0.0-20260512113608-deb4dc54551a
github.com/openshift/client-go v0.0.0-20260618131434-17fd91ed6167
github.com/pkg/errors v0.9.1
github.com/pkg/profile v1.7.0
github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring v0.74.0
github.com/prometheus/client_golang v1.23.2
github.com/robfig/cron v1.2.0
github.com/sirupsen/logrus v1.9.3
github.com/spf13/cobra v1.10.0
github.com/spf13/pflag v1.0.9
github.com/spf13/pflag v1.0.10
github.com/stretchr/testify v1.11.1
go.etcd.io/etcd/client/v3 v3.6.5
golang.org/x/crypto v0.45.0
golang.org/x/net v0.47.0
golang.org/x/sys v0.38.0
golang.org/x/crypto v0.48.0
golang.org/x/net v0.50.0
golang.org/x/sys v0.41.0
Comment on lines +21 to +36

@coderabbitai coderabbitai Bot Jun 22, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🌐 Web query:

Are there any known CVEs in golang.org/x/crypto v0.48.0, golang.org/x/net v0.50.0, and golang.org/x/sys v0.41.0?

💡 Result:

Yes. 1) golang.org/x/crypto v0.48.0 There are multiple Go security advisories listed for this exact version (as OSV entries): GO-2026-5005, GO-2026-5006, GO-2026-5013, GO-2026-5014, GO-2026-5015, GO-2026-5016, GO-2026-5017, GO-2026-5018, GO-2026-5019, GO-2026-5020, GO-2026-5021, GO-2026-5023, and GO-2026-5033.[1] 2) golang.org/x/net v0.50.0 There is at least one known CVE: CVE-2026-27141 (OSV: GO-2026-4559), which affects golang.org/x/net/http2 in the range 0.50.0 (and before 0.51.0). It is described as a server panic issue triggered by sending certain HTTP/2 frames due to a missing nil check.[2][3] 3) golang.org/x/sys v0.41.0 There is at least one known CVE: OSV entry GO-2026-5024 is listed for golang.org/x/sys v0.41.0, and the OSV record is aliased to CVE-2026-39824.[4][5] If you want, I can enumerate the specific CVEs behind each GO-xxxx advisory for golang.org/x/crypto v0.48.0 as well (the pkg.go.dev page lists the GO-ids, and you’d typically map those to CVEs via each OSV record).

Citations:

🏁 Script executed:

#!/bin/bash
# Check osv.dev database for known vulnerabilities in cryptographic and networking libraries

for pkg in "golang.org/x/crypto" "golang.org/x/net" "golang.org/x/sys"; do
  echo "=== Checking $pkg ==="
  curl -s "https://api.osv.dev/v1/query" \
    -X POST \
    -H "Content-Type: application/json" \
    -d "{\"package\": {\"ecosystem\": \"Go\", \"name\": \"$pkg\"}, \"version\": \"\"}" | jq '.vulns[]'
done

Repository: openshift/library-go

Length of output: 50377

Do not merge: critical CVEs in security-sensitive dependencies.

golang.org/x/net v0.50.0 contains CVE-2026-27141 (HTTP/2 server panic due to missing nil check), golang.org/x/sys v0.41.0 contains CVE-2026-39824, and golang.org/x/crypto v0.48.0 is affected by multiple known Go security advisories (GO-2026-5005, GO-2026-5006, GO-2026-5013, GO-2026-5014, GO-2026-5015, GO-2026-5016, GO-2026-5017, GO-2026-5018, GO-2026-5019, GO-2026-5020, GO-2026-5021, GO-2026-5023, GO-2026-5033). These versions must be updated to release patches or explicitly justified if usage context mitigates the risk.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@go.mod` around lines 21 - 36, Update the vulnerable versions of three
security-sensitive dependencies in go.mod to patched releases that address the
reported CVEs. Specifically, upgrade golang.org/x/net from v0.50.0 to a newer
patch version that resolves CVE-2026-27141, upgrade golang.org/x/sys from
v0.41.0 to address CVE-2026-39824, and upgrade golang.org/x/crypto from v0.48.0
to a version that resolves all listed Go security advisories (GO-2026-5005
through GO-2026-5033). Check the Go security advisories database and the
respective package repositories to determine the minimum safe versions, then run
go get to update these dependencies and ensure go.mod and go.sum are properly
updated with the new versions.

golang.org/x/time v0.9.0
gopkg.in/evanphx/json-patch.v4 v4.13.0
gopkg.in/gcfg.v1 v1.2.3
Expand All @@ -44,10 +44,10 @@ require (
k8s.io/apiserver v0.35.1
k8s.io/client-go v0.35.1
k8s.io/component-base v0.35.1
k8s.io/klog/v2 v2.130.1
k8s.io/klog/v2 v2.140.0
k8s.io/kms v0.35.1
k8s.io/kube-aggregator v0.35.1
k8s.io/utils v0.0.0-20251002143259-bc988d571ff4
k8s.io/utils v0.0.0-20260210185600-b8788abfbbc2
sigs.k8s.io/kube-storage-version-migrator v0.0.6-0.20230721195810-5c8923c5ff96
sigs.k8s.io/yaml v1.6.0
)
Expand All @@ -66,7 +66,7 @@ require (
github.com/cyphar/filepath-securejoin v0.6.0 // indirect
github.com/docker/go-metrics v0.0.1 // indirect
github.com/docker/libtrust v0.0.0-20160708172513-aabc10ec26b7 // indirect
github.com/emicklei/go-restful/v3 v3.12.2 // indirect
github.com/emicklei/go-restful/v3 v3.13.0 // indirect
github.com/felixge/fgprof v0.9.4 // indirect
github.com/felixge/httpsnoop v1.0.4 // indirect
github.com/fsnotify/fsnotify v1.9.0 // indirect
Expand All @@ -76,7 +76,18 @@ require (
github.com/go-logr/stdr v1.2.2 // indirect
github.com/go-openapi/jsonpointer v0.21.0 // indirect
github.com/go-openapi/jsonreference v0.20.2 // indirect
github.com/go-openapi/swag v0.23.0 // indirect
github.com/go-openapi/swag v0.25.4 // indirect
github.com/go-openapi/swag/cmdutils v0.25.4 // indirect
github.com/go-openapi/swag/conv v0.25.4 // indirect
github.com/go-openapi/swag/fileutils v0.25.4 // indirect
github.com/go-openapi/swag/jsonname v0.25.4 // indirect
github.com/go-openapi/swag/jsonutils v0.25.4 // indirect
github.com/go-openapi/swag/loading v0.25.4 // indirect
github.com/go-openapi/swag/mangling v0.25.4 // indirect
github.com/go-openapi/swag/netutils v0.25.4 // indirect
github.com/go-openapi/swag/stringutils v0.25.4 // indirect
github.com/go-openapi/swag/typeutils v0.25.4 // indirect
github.com/go-openapi/swag/yamlutils v0.25.4 // indirect
github.com/gogo/protobuf v1.3.2 // indirect
github.com/golang/protobuf v1.5.4 // indirect
github.com/gonum/blas v0.0.0-20181208220705-f22b278b28ac // indirect
Expand All @@ -93,10 +104,8 @@ require (
github.com/grpc-ecosystem/grpc-gateway/v2 v2.26.3 // indirect
github.com/hashicorp/golang-lru v0.5.4 // indirect
github.com/inconshreveable/mousetrap v1.1.0 // indirect
github.com/josharian/intern v1.0.0 // indirect
github.com/json-iterator/go v1.1.12 // indirect
github.com/kylelemons/godebug v1.1.0 // indirect
github.com/mailru/easyjson v0.7.7 // indirect
github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect
github.com/modern-go/reflect2 v1.0.3-0.20250322232337-35a7c28c31ee // indirect
github.com/opencontainers/image-spec v1.0.2 // indirect
Expand Down Expand Up @@ -124,20 +133,20 @@ require (
go.yaml.in/yaml/v3 v3.0.4 // indirect
golang.org/x/exp v0.0.0-20240719175910-8a7402abbf56 // indirect
golang.org/x/oauth2 v0.30.0 // indirect
golang.org/x/sync v0.18.0 // indirect
golang.org/x/term v0.37.0 // indirect
golang.org/x/text v0.31.0 // indirect
golang.org/x/tools v0.38.0 // indirect
golang.org/x/sync v0.19.0 // indirect
golang.org/x/term v0.40.0 // indirect
golang.org/x/text v0.34.0 // indirect
golang.org/x/tools v0.42.0 // indirect
google.golang.org/genproto/googleapis/api v0.0.0-20250303144028-a0af3efb3deb // indirect
google.golang.org/genproto/googleapis/rpc v0.0.0-20250528174236-200df99c418a // indirect
google.golang.org/grpc v1.72.2 // indirect
google.golang.org/protobuf v1.36.8 // indirect
gopkg.in/inf.v0 v0.9.1 // indirect
gopkg.in/warnings.v0 v0.1.2 // indirect
gopkg.in/yaml.v3 v3.0.1 // indirect
k8s.io/kube-openapi v0.0.0-20250910181357-589584f1c912 // indirect
k8s.io/kube-openapi v0.0.0-20260519202549-bbf5c5577288 // indirect
sigs.k8s.io/apiserver-network-proxy/konnectivity-client v0.31.2 // indirect
sigs.k8s.io/json v0.0.0-20250730193827-2d320260d730 // indirect
sigs.k8s.io/randfill v1.0.0 // indirect
sigs.k8s.io/structured-merge-diff/v6 v6.3.0 // indirect
sigs.k8s.io/structured-merge-diff/v6 v6.3.2 // indirect
)
Loading