Skip to content

NO-JIRA: EnforcesSecuritySettings deprecates SecureTLSConfig #2250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hongkailiu wants to merge 2 commits into
base: master
Choose a base branch
from
Open

NO-JIRA: EnforcesSecuritySettings deprecates SecureTLSConfig #2250

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f79333
EnforcesSecuritySettings deprecates SecureTLSConfig
hongkailiu May 29, 2026
cb8b4fe
Do not modify tls.Config's PreferServerCipherSuites
hongkailiu May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions pkg/crypto/crypto.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,16 +309,21 @@ func DefaultCiphers() []uint16 {
}

// SecureTLSConfig enforces the default minimum security settings for the cluster.
// Deprecated: use EnforcesSecuritySettings instead.
func SecureTLSConfig(config *tls.Config) *tls.Config {
EnforcesSecuritySettings(config)
return config
}

// EnforcesSecuritySettings enforces the default minimum security settings for the cluster on the given TLS config.
func EnforcesSecuritySettings(config *tls.Config) {
if config.MinVersion == 0 {
config.MinVersion = DefaultTLSVersion()
}

config.PreferServerCipherSuites = true
if len(config.CipherSuites) == 0 {
config.CipherSuites = DefaultCiphers()
}
return config
}

// OpenSSLToIANACipherSuites maps input OpenSSL Cipher Suite names to their
Expand Down