Skip to content

CCXDEV-16450: document disableRuntimeExtractor config option#1312

Open
opokornyy wants to merge 1 commit into
openshift:masterfrom
opokornyy:CCXDEV-16450-docs-disableRuntimeExtractor
Open

CCXDEV-16450: document disableRuntimeExtractor config option#1312
opokornyy wants to merge 1 commit into
openshift:masterfrom
opokornyy:CCXDEV-16450-docs-disableRuntimeExtractor

Conversation

@opokornyy

@opokornyy opokornyy commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Add disableRuntimeExtractor configuration to arch.md and CLAUDE.md. This configmap-only option disables runtime-extractor resources when set to true.

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • None

Documentation

  • docs/arch.md

Unit Tests

  • None

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

  • None

Breaking Changes

No

References

https://redhat.atlassian.net/browse/CCXDEV-16450

Summary by CodeRabbit

  • Documentation
    • Added/updated scheduling guidance for the Runtime Extractor Controller, including the periodic task that manages the runtime extractor DaemonSet lifecycle.
    • Documented the dataReporting/disableRuntimeExtractor setting, explaining how setting it to true disables runtime extractor deployment and management (default: false).
    • Updated the sample insights-config configmap to include the new option and default value.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 25, 2026
@openshift-ci-robot

openshift-ci-robot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

@opokornyy: This pull request references CCXDEV-16450 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Add disableRuntimeExtractor configuration to arch.md and CLAUDE.md. This configmap-only option disables runtime-extractor resources when set to true.

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • None

Documentation

  • docs/arch.md

Unit Tests

  • None

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

  • None

Breaking Changes

No

References

https://redhat.atlassian.net/browse/CCXDEV-16450

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from katushiik11 and ncaak June 25, 2026 07:32
@openshift-ci

openshift-ci Bot commented Jun 25, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: opokornyy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 6d4c814d-699a-40ab-b9e0-709e905b6d0f

📥 Commits

Reviewing files that changed from the base of the PR and between 6e8579e and bb1332e.

📒 Files selected for processing (2)
  • CLAUDE.md
  • docs/arch.md
✅ Files skipped from review due to trivial changes (2)
  • CLAUDE.md
  • docs/arch.md

📝 Walkthrough

Walkthrough

Documentation was updated to describe the dataReporting.disableRuntimeExtractor setting and the Runtime Extractor Controller’s scheduling role.

Changes

Runtime extractor documentation

Layer / File(s) Summary
Config setting docs
docs/arch.md
docs/arch.md adds the dataReporting.disableRuntimeExtractor example value and explains the configmap attribute and default.
Scheduling guidance
CLAUDE.md
CLAUDE.md adds the Runtime Extractor Controller to the scheduling pattern guidance with its DaemonSet management note and disable flag.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately summarizes the documented disableRuntimeExtractor config option.
Description check ✅ Passed The description covers the required template sections and is mostly complete for a documentation-only change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR only updates docs (CLAUDE.md, docs/arch.md); no Ginkgo test titles were added or changed.
Test Structure And Quality ✅ Passed PR only updates CLAUDE.md and docs/arch.md; no Ginkgo test files were changed, so this check is not applicable.
Microshift Test Compatibility ✅ Passed Docs-only PR (CLAUDE.md, docs/arch.md); no new Ginkgo/e2e tests or OpenShift API usage were added, so MicroShift compatibility is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS: The PR only changes CLAUDE.md and docs/arch.md; no new Ginkgo/e2e tests or node-topology assumptions were added.
Topology-Aware Scheduling Compatibility ✅ Passed Only documentation files changed; no deployment manifests, controllers, or scheduling logic were added or modified.
Ote Binary Stdout Contract ✅ Passed The PR only changes CLAUDE.md and docs/arch.md; no process-level code or stdout logging was introduced.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS: The PR only updates CLAUDE.md and docs/arch.md; no Ginkgo e2e tests or networking code were added.
No-Weak-Crypto ✅ Passed The patch only adds docs for disableRuntimeExtractor, and the added lines contain no weak-cipher, custom-crypto, or secret-comparison code.
Container-Privileges ✅ Passed PASS: PR only edits CLAUDE.md and docs/arch.md; no K8s/container manifests were changed, and the edited files contain no privileged or escalation settings.
No-Sensitive-Data-In-Logs ✅ Passed Docs-only change adds a config flag description; no log statements or sensitive values/PII were introduced.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2026
Add disableRuntimeExtractor configuration to
arch.md and CLAUDE.md. This configmap-only
option disables runtime-extractor resources
when set to true.

Signed-off-by: Ondrej Pokorny <opokorny@redhat.com>
@opokornyy opokornyy force-pushed the CCXDEV-16450-docs-disableRuntimeExtractor branch from 6e8579e to bb1332e Compare June 25, 2026 11:25
@openshift-ci

openshift-ci Bot commented Jun 25, 2026

Copy link
Copy Markdown

@opokornyy: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants