[release-4.21] OCPBUGS-91985: fall back to kube-system/global-pull-secret for Insights token by openshift-cherrypick-robot · Pull Request #1310 · openshift/insights-operator

openshift-cherrypick-robot · 2026-06-24T07:05:22Z

This is an automated cherry-pick of #1302

/assign opokornyy

On ARO HCP clusters, openshift-config/pull-secret only contains the ACR registry credential — no cloud.openshift.com token. Customers add their Red Hat pull secret (including cloud.openshift.com) day-2 via the additional-pull-secret method, which HCCO merges into kube-system/global-pull-secret. This change makes updateToken() check kube-system/global-pull-secret as a fallback when openshift-config/pull-secret has no cloud.openshift.com token, enabling Insights reporting on HCP clusters without requiring platform-level changes. Changes: - Generalize fetchSecret() to accept a namespace parameter - Add fallback lookup to kube-system/global-pull-secret in updateToken() - Add read-only RBAC (Role+RoleBinding) for global-pull-secret in kube-system - Include namespace in fetchSecret log/error messages for debuggability - Add tests for fallback and primary-wins-over-fallback precedence Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Addresses review feedback to replace hardcoded string literals with named constants for better readability and maintainability. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

coderabbitai · 2026-06-24T07:05:33Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 77292efb-5d23-419f-b534-204e27f24d36

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands.}

opokornyy · 2026-06-24T07:06:06Z

/cc @judexzhu

openshift-ci-robot · 2026-06-24T07:06:36Z

@openshift-cherrypick-robot: Jira Issue OCPBUGS-87889 has been cloned as Jira Issue OCPBUGS-91985. Will retitle bug to link to clone.
/retitle [release-4.21] OCPBUGS-91985: fall back to kube-system/global-pull-secret for Insights token

Details

In response to this:

This is an automated cherry-pick of #1302

/assign opokornyy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-06-24T07:06:44Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-91985, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected dependent Jira Issue OCPBUGS-87889 to target a version in 4.22.0, but it targets "5.0.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #1302

/assign opokornyy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

opokornyy · 2026-06-24T07:08:45Z

/jira refresh

openshift-ci-robot · 2026-06-24T07:08:50Z

@opokornyy: This pull request references Jira Issue OCPBUGS-91985, which is invalid:

expected dependent Jira Issue OCPBUGS-88026 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

opokornyy · 2026-06-24T10:04:12Z

/test insights-runtime-extractor-tests

opokornyy · 2026-06-24T10:20:39Z

/retest

opokornyy · 2026-06-24T12:28:01Z

/retest

judexzhu · 2026-06-24T15:28:13Z

/lgtm

judexzhu · 2026-06-24T15:28:26Z

/retest-required

opokornyy · 2026-06-25T06:45:06Z

/retest

opokornyy · 2026-06-25T12:38:45Z

/override ci/prow/e2e-gcp-ovn-techpreview

Failures are caused by a known issue in the python kubernetes client

opokornyy · 2026-06-25T12:38:58Z

/override ci/prow/insights-operator-e2e-tests

Failures are caused by a known issue in the python kubernetes client

openshift-ci · 2026-06-25T12:40:46Z

@opokornyy: Overrode contexts on behalf of opokornyy: ci/prow/e2e-gcp-ovn-techpreview

Details

In response to this:

/override ci/prow/e2e-gcp-ovn-techpreview

Failures are caused by a known issue in the python kubernetes client

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci · 2026-06-25T12:40:56Z

@opokornyy: Overrode contexts on behalf of opokornyy: ci/prow/insights-operator-e2e-tests

Details

In response to this:

/override ci/prow/insights-operator-e2e-tests

Failures are caused by a known issue in the python kubernetes client

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci · 2026-06-25T12:40:59Z

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-ovn-techpreview	`2069d58`	link	true	`/test e2e-gcp-ovn-techpreview`
ci/prow/insights-operator-e2e-tests	`2069d58`	link	true	`/test insights-operator-e2e-tests`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

opokornyy · 2026-06-25T12:42:29Z

/lgtm

opokornyy · 2026-06-25T12:42:36Z

/approve

opokornyy · 2026-06-25T12:42:45Z

/verified later @judexzhu

openshift-ci-robot · 2026-06-25T12:42:59Z

@opokornyy: This PR has been marked to be verified later by @judexzhu.

Details

In response to this:

/verified later @judexzhu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-06-25T12:43:08Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, opokornyy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [opokornyy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

judexzhu and others added 2 commits June 24, 2026 07:05

refactor: extract namespace and secret names into constants

2069d58

Addresses review feedback to replace hardcoded string literals with named constants for better readability and maintainability. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

openshift-cherrypick-robot assigned opokornyy Jun 24, 2026

openshift-cherrypick-robot mentioned this pull request Jun 24, 2026

OCPBUGS-87889: fall back to kube-system/global-pull-secret for Insights token #1302

Merged

5 tasks

openshift-ci Bot requested review from katushiik11 and opokornyy June 24, 2026 07:05

openshift-ci Bot requested a review from judexzhu June 24, 2026 07:06

openshift-ci Bot changed the title ~~[release-4.21] OCPBUGS-87889: fall back to kube-system/global-pull-secret for Insights token~~ [release-4.21] OCPBUGS-91985: fall back to kube-system/global-pull-secret for Insights token Jun 24, 2026

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 24, 2026

openshift-ci Bot assigned judexzhu Jun 24, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2026

openshift-ci-robot added verified-later verified Signifies that the PR passed pre-merge verification criteria labels Jun 25, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2026

Uh oh!

Conversation

openshift-cherrypick-robot commented Jun 24, 2026

Uh oh!

coderabbitai Bot commented Jun 24, 2026

Review skipped

Uh oh!

opokornyy commented Jun 24, 2026

Uh oh!

openshift-ci-robot commented Jun 24, 2026

Uh oh!

openshift-ci-robot commented Jun 24, 2026

Uh oh!

opokornyy commented Jun 24, 2026

Uh oh!

openshift-ci-robot commented Jun 24, 2026

Uh oh!

opokornyy commented Jun 24, 2026

Uh oh!

opokornyy commented Jun 24, 2026

Uh oh!

opokornyy commented Jun 24, 2026

Uh oh!

judexzhu commented Jun 24, 2026

Uh oh!

judexzhu commented Jun 24, 2026

Uh oh!

opokornyy commented Jun 25, 2026

Uh oh!

opokornyy commented Jun 25, 2026

Uh oh!

opokornyy commented Jun 25, 2026

Uh oh!

openshift-ci Bot commented Jun 25, 2026

Uh oh!

openshift-ci Bot commented Jun 25, 2026

Uh oh!

openshift-ci Bot commented Jun 25, 2026

Uh oh!

opokornyy commented Jun 25, 2026

Uh oh!

opokornyy commented Jun 25, 2026

Uh oh!

opokornyy commented Jun 25, 2026

Uh oh!

openshift-ci-robot commented Jun 25, 2026

Uh oh!

openshift-ci Bot commented Jun 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants