Skip to content

Hive-3130: bundle-gen rewrite + port to shell #2916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
suhanime wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Hive-3130: bundle-gen rewrite + port to shell #2916

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f4ea6b6
HIVE-3130: Rewrite bundle-gen.py as bundle-gen.sh
suhanime Jun 1, 2026
5edfc55
HIVE-3130: Fix overly broad help flag matching in generate-saas-templ…
suhanime Jun 1, 2026
090e847
HIVE-3130: Fix version prefix when --commit targets a non-HEAD commit
suhanime Jun 5, 2026
4152150
HIVE-3130: Address CodeRabbit review suggestions
suhanime Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions config/templates/hive-csv-template.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,10 +108,10 @@ spec:
spec:
clusterPermissions:
- serviceAccountName: hive-operator
# Rules will be added here by the bundle-gen.py script.
# Rules will be added here by the bundle-gen.sh script.
deployments:
- name: hive-operator
# Deployment spec will be added here by the bundle-gen.py script.
# Deployment spec will be added here by the bundle-gen.sh script.
customresourcedefinitions:
owned:
- description: Configuration for the Hive Operator
Expand Down
17 changes: 9 additions & 8 deletions hack/app-sre/generate-saas-template.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,19 +22,20 @@ Parameters:
EOF
}

# Check for help flag or incorrect number of arguments
if [ $# -ne 3 ]; then
usage
exit 1
fi

# Check for help flag
for arg in "$@"; do
if [[ "$arg" == *"-h"* ]]; then
if [[ "$arg" == "-h" || "$arg" == "--help" ]]; then
usage
exit 1
exit 0
fi
done

# Check for incorrect number of arguments
if [ $# -ne 3 ]; then
usage
exit 1
fi

saas_template_stub="$1"
saas_object_file="$2"
out_file="$3"
Expand Down
Loading