CONSOLE-5163: Enhancement for Ingress componentRoutes labels#2033
CONSOLE-5163: Enhancement for Ingress componentRoutes labels#2033Leo6Leo wants to merge 6 commits into
Conversation
Add enhancement proposal for a labels field on ComponentRouteSpec in the Ingress config API. This enables cluster admins to specify labels on component-managed routes for IngressController route sharding scenarios.
- Add missing metadata (status, see-also) - Fix Go type to map[string]LabelValue matching implementation - Add required sections: Drawbacks, Alternatives, OKE topology, Open Questions - Expand Workflow Description with actors, starting state, and failure cases - Add Label Conflict and Removal Behavior section - Expand Operational Aspects with failure modes, SLI impact, escalation - Expand Support Procedures with diagnostic oc commands - Remove false test plan claim (empty labels map test) - Update last-updated date
openshift-ci-robot
added
the
jira/valid-reference
|
@Leo6Leo: This pull request references CONSOLE-5163 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
spadgett
left a comment
spadgett
left a comment
There was a problem hiding this comment.
/approve
/cc @Miciah @everettraven
@Leo6Leo, thanks! Looks like the PR has some markdown lint errors.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
| approvers: | ||
| - TBD | ||
| api-approvers: | ||
| - TBD |
There was a problem hiding this comment.
Once @saschagrunert signals he is happy with the state of openshift/api#2845 I'll give both this enhancement and that o/api PR a look
|
@Leo6Leo: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
4 participants
Summary
Add a
labelsfield toComponentRouteSpecin the Ingress config API (config.openshift.io/v1). This enables cluster administrators to specify labels on component-managed routes so that IngressControllers using route selectors can manage them for route sharding scenarios.This enhancement covers the API change only. Operator-side consumption is tracked separately per operator.
API Change
LabelValuevalidated string type inconfig/v1/types_ingress.goLabels map[string]LabelValuefield onComponentRouteSpecIngressComponentRouteLabelsFeatureGate (TechPreviewNoUpgrade, DevPreviewNoUpgrade)format.qualifiedName()for keys,format.labelValue()for values, reserved prefix rejectionMinProperties=1,MaxProperties=8,+mapType=granularRelated
Test plan
hack/template-lint.sh)🤖 Generated with Claude Code