Update boilerplate#812
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
✅ Files skipped from review due to trivial changes (2)
WalkthroughBump CI build root image tag from ChangesCI Operator Build Image Update
Dependabot Configuration
OWNERS Aliases Cleanup
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 9 | ❌ 3❌ Failed checks (3 warnings)
✅ Passed checks (9 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: abyrne55 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
3784cb9 to
152057d
Compare
|
/retest |
|
@abyrne55: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #812 +/- ##
==========================================
+ Coverage 38.38% 41.01% +2.63%
==========================================
Files 67 68 +1
Lines 6313 6995 +682
==========================================
+ Hits 2423 2869 +446
- Misses 3747 3959 +212
- Partials 143 167 +24 🚀 New features to boost your workflow:
|
| @@ -0,0 +1,14 @@ | |||
| version: 2 | |||
There was a problem hiding this comment.
Thanks for the PR!
I did not realize the dependabot config is from boilerplate when i moved this logic to konflux's renovate.
Looks like boilerplate now has both a renovate config and dependabot, which should result in duplicate PRs
https://github.com/openshift/boilerplate/blob/master/.github/renovate.json
https://github.com/openshift/boilerplate/blob/master/boilerplate/openshift/golang-osd-operator/dependabot.yml
https://github.com/openshift/configuration-anomaly-detection/blob/main/.github/renovate.json
Currently we have ^ config extending the one from boilerplate, which should make dependabot obsolete. If it does work as intended, we should probably move it to boilerplate and remove dependabot. ( it would require boilerplate consumers to be on konflux though )
We may want to hold this PR for a bit and figure out whats a good course of action. ( to fix cad, we can probably remove https://github.com/openshift/boilerplate/blob/master/boilerplate/openshift/osd-container-image/dependabot.yml from boilerplate as cad was the only consumer last time i checked :D
There was a problem hiding this comment.
I think it's because this repo uses boilerplate/openshift/osd-container-image vs the operator one. Either way, +1 for using renovate with Konflux and removing the boilerplate config imo.
Sync with latest boilerplate (61dbfdf)
Summary by CodeRabbit