Skip to content

[WIP] [SREP-726] Add investigation to rotate non-STS credentials#757

Open
bergmannf wants to merge 2 commits into
openshift:mainfrom
bergmannf:srep-726-rotate-credentials
Open

[WIP] [SREP-726] Add investigation to rotate non-STS credentials#757
bergmannf wants to merge 2 commits into
openshift:mainfrom
bergmannf:srep-726-rotate-credentials

Conversation

@bergmannf

Copy link
Copy Markdown
Contributor

What type of PR is this?

feature

What this PR does / Why we need it?

It moves the ability to rotate non-STS customer credentials into CAD.

It also adds steps to disable the old AWS key should the new one have been successfully used.

This PR is WIP and must be held as testing this change is quite difficult.

Special notes for your reviewer

Test Coverage

Guidelines for CAD investigations

  • New investgations should be accompanied by unit tests and/or step-by-step manual tests in the investigation README.
  • Actioning investigations should be locally tested in staging, and E2E testing is desired. See README for more info on investigation graduation process.

Test coverage checks

  • Added tests
  • Created jira card to add unit test
  • This PR may not need unit tests

Pre-checks (if applicable)

  • Ran unit tests locally
  • Validated the changes in a cluster
  • Included documentation changes with PR

@coderabbitai

coderabbitai Bot commented Apr 8, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Excluded labels (none allowed) (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 48f55eee-e4a0-4cdb-b5ce-0bce0f16f979

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@bergmannf

Copy link
Copy Markdown
Contributor Author

/hold

@openshift-ci openshift-ci Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 8, 2026
@openshift-ci openshift-ci Bot requested review from joshbranham and zmird-r April 8, 2026 12:16
@openshift-ci

openshift-ci Bot commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bergmannf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2026
@bergmannf bergmannf force-pushed the srep-726-rotate-credentials branch from 548bb26 to 15f1a5f Compare April 8, 2026 12:18
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 8, 2026
@codecov-commenter

codecov-commenter commented Apr 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 471 lines in your changes missing coverage. Please review.
✅ Project coverage is 32.57%. Comparing base (000241e) to head (90abc5d).

Files with missing lines Patch % Lines
...estigations/rotatecredentials/rotatecredentials.go 0.00% 364 Missing ⚠️
pkg/backplane/mock/backplanemock.go 0.00% 47 Missing ⚠️
pkg/investigations/investigation/investigation.go 0.00% 41 Missing ⚠️
pkg/backplane/backplane.go 0.00% 19 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #757      +/-   ##
==========================================
- Coverage   35.23%   32.57%   -2.66%     
==========================================
  Files          64       65       +1     
  Lines        5577     6032     +455     
==========================================
  Hits         1965     1965              
- Misses       3489     3944     +455     
  Partials      123      123              
Files with missing lines Coverage Δ
pkg/investigations/registry.go 0.00% <ø> (ø)
pkg/backplane/backplane.go 23.72% <0.00%> (-4.00%) ⬇️
pkg/investigations/investigation/investigation.go 16.95% <0.00%> (-3.26%) ⬇️
pkg/backplane/mock/backplanemock.go 0.00% <0.00%> (ø)
...estigations/rotatecredentials/rotatecredentials.go 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This should be transparent for users - so a management client for a
classic cluster will get hive access.
@bergmannf bergmannf force-pushed the srep-726-rotate-credentials branch from 15f1a5f to 90abc5d Compare April 8, 2026 12:34
@openshift-ci

openshift-ci Bot commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

@bergmannf: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/validate 90abc5d link true /test validate
ci/prow/lint 90abc5d link true /test lint

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants