[WIP] [SREP-726] Add investigation to rotate non-STS credentials#757
[WIP] [SREP-726] Add investigation to rotate non-STS credentials#757bergmannf wants to merge 2 commits into
Conversation
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Excluded labels (none allowed) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/hold |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bergmannf The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
548bb26 to
15f1a5f
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #757 +/- ##
==========================================
- Coverage 35.23% 32.57% -2.66%
==========================================
Files 64 65 +1
Lines 5577 6032 +455
==========================================
Hits 1965 1965
- Misses 3489 3944 +455
Partials 123 123
🚀 New features to boost your workflow:
|
This should be transparent for users - so a management client for a classic cluster will get hive access.
15f1a5f to
90abc5d
Compare
|
@bergmannf: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
feature
What this PR does / Why we need it?
It moves the ability to rotate non-STS customer credentials into CAD.
It also adds steps to disable the old AWS key should the new one have been successfully used.
This PR is WIP and must be held as testing this change is quite difficult.
Special notes for your reviewer
Test Coverage
Guidelines for CAD investigations
Test coverage checks
Pre-checks (if applicable)