WIP: Fake bump#717
Conversation
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
/test e2e-aws-operator-encryption-kms |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Walkthrough
ChangesKMS Plugin Sidecar Parameter Updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 10 | ❌ 5❌ Failed checks (4 warnings, 1 inconclusive)
✅ Passed checks (10 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@go.mod`:
- Around line 136-139: The replace directive contains a redirect from
github.com/openshift/library-go to a personal fork
github.com/ardaguclu/library-go, which lacks documented justification and
contradicts the README.md documentation. Either remove this redirect line
entirely from the replace block, or if it is necessary, add explicit written
justification as a comment and obtain documented approval from security and
maintainers before merging to protected branches to mitigate supply chain
security risks.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 7c677642-9c6e-4170-b86e-372f3f1c8b74
⛔ Files ignored due to path filters (9)
go.sumis excluded by!**/*.sumvendor/github.com/openshift/library-go/pkg/operator/encryption/controllers/key_controller.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/pkg/operator/encryption/controllers/kms_preflight_controller.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/pkg/operator/encryption/kms/pluginlifecycle/builder.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/pkg/operator/encryption/kms/pluginlifecycle/sidecar.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/test/library/encryption/helpers.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/test/library/encryption/kms/vault.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/test/library/encryption/scenarios.gois excluded by!**/vendor/**,!vendor/**vendor/modules.txtis excluded by!**/vendor/**,!vendor/**
📒 Files selected for processing (2)
go.modpkg/operator/workload/workload_openshiftapiserver_v311_00_sync.go
| replace ( | ||
| github.com/onsi/ginkgo/v2 => github.com/openshift/onsi-ginkgo/v2 v2.6.1-0.20260303184444-1cc650aa0565 | ||
| github.com/openshift/library-go => github.com/ardaguclu/library-go v0.0.0-20260619072729-555fb535777b | ||
| ) |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "library-go replace directives in go.mod:"
rg -n 'github.com/openshift/library-go\s*=>' go.mod || true
echo
echo "Current replace block:"
sed -n '/^replace/,/)/p' go.modRepository: openshift/cluster-openshift-apiserver-operator
Length of output: 480
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "=== Checking context around line 138 in go.mod ==="
sed -n '130,150p' go.mod
echo
echo "=== Searching for any comments explaining the library-go redirect ==="
rg -B3 -A3 'ardaguclu/library-go' go.mod || true
echo
echo "=== Checking if there are any TODO/FIXME comments related to this ==="
rg -i 'todo|fixme|temporary|test-only' go.mod || true
echo
echo "=== Checking git history for this file (last 5 commits) ==="
git log --oneline -5 -- go.mod || echo "Git history not available"Repository: openshift/cluster-openshift-apiserver-operator
Length of output: 1093
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "=== Checking if there's any reference to ardaguclu in other files ==="
rg -l 'ardaguclu' --type-list | head -20 || true
rg 'ardaguclu' --type-list 2>/dev/null | head -30 || true
echo
echo "=== Searching for any justification in README or similar ==="
find . -maxdepth 2 -type f \( -name "README*" -o -name "CONTRIBUTING*" \) -exec grep -l 'library-go\|ardaguclu' {} \; || echo "No matches in docs"
echo
echo "=== Checking go.sum for related entries ==="
rg 'ardaguclu' go.sum || echo "No ardaguclu entries in go.sum"Repository: openshift/cluster-openshift-apiserver-operator
Length of output: 924
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "=== Checking README.md for library-go or ardaguclu context ==="
grep -B2 -A2 'library-go\|ardaguclu' README.md || echo "No direct mentions in README"
echo
echo "=== Full go.mod replace section with line numbers ==="
sed -n '134,140p' go.modRepository: openshift/cluster-openshift-apiserver-operator
Length of output: 825
Remove personal-fork redirect or provide explicit justification before merge.
Line 138 redirects github.com/openshift/library-go to a personal fork (github.com/ardaguclu/library-go). This lacks documented justification, contradicts the README.md (which references the official upstream library-go), and presents a supply chain security risk. Either remove this redirect or provide written justification and approval from security/maintainers before merging to protected branches.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@go.mod` around lines 136 - 139, The replace directive contains a redirect
from github.com/openshift/library-go to a personal fork
github.com/ardaguclu/library-go, which lacks documented justification and
contradicts the README.md documentation. Either remove this redirect line
entirely from the replace block, or if it is necessary, add explicit written
justification as a comment and obtain documented approval from security and
maintainers before merging to protected branches to mitigate supply chain
security risks.
Source: Coding guidelines
|
/test e2e-aws-operator-encryption-kms |
|
/test e2e-aws-operator-encryption-kms |
|
@ardaguclu: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-ci
Bot
added
the
needs-rebase
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/close |
|
@ardaguclu: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
1 participant
In order to test openshift/library-go#2317
Summary by CodeRabbit